New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CSI Spec to 1.0.0 and gRPC to 1.13.0 #71020

Merged
merged 4 commits into from Nov 16, 2018

Conversation

@saad-ali
Copy link
Member

saad-ali commented Nov 14, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR picks up CSI spec v1.0.0

It also bumps the gRPC version since that is out of date.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/enhancements#178

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kubernetes v1.13 moves support for Container Storage Interface to GA. As part of this move Kubernetes now supports CSI v1.0.0 and drops support for CSI 0.3 and older releases. Older CSI drivers must be updated to CSI 1.0 in order to work with Kubernetes 1.13+.
@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 14, 2018

CSI Tests will fail until the drivers have been updated to pick up 1.0.0.

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 14, 2018

@saad-ali how much delta time window are we looking between bumping CSI Spec to 1.0.0 and updating the drivers? Could you please ping this issue when everything is updated and CSI tests are expected to pass again?

@jberkus @mariantalla @mortent as FYI on upcoming CSI test failures in CI signal

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 14, 2018

/milestone v1.13
/priority important-soon

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 14, 2018

@saad-ali how much delta time window are we looking between bumping CSI Spec to 1.0.0 and updating the drivers? Could you please ping this issue when everything is updated and CSI tests are expected to pass again?

We're planning to update the drivers Wed. Will keep this issue updated.

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Nov 14, 2018

FYI csi tests are run as part of pull now so we cannot merge this PR until all CI drivers are updated. Also we will run the non pull csi tests (serial, slow, alpha) to minimize the possibility of test breakage post merge.

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 14, 2018

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-verify

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 14, 2018

/assign @thockin
To unblock approvals while we work on the CSI E2E tests fixes

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Nov 14, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 14, 2018

@saad-ali saad-ali force-pushed the saad-ali:updateCSI10 branch from ffe7a52 to 519eee7 Nov 15, 2018

@@ -15,7 +15,7 @@ spec:
hostNetwork: true
containers:

This comment has been minimized.

@davidz627

davidz627 Nov 15, 2018

Contributor

I think this line:

might need to get changed to csi-node-sa based on the other changes

This comment has been minimized.

@saad-ali

saad-ali Nov 15, 2018

Member

Fixed.

@saad-ali saad-ali force-pushed the saad-ali:updateCSI10 branch from 519eee7 to 71ef08f Nov 15, 2018

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 16, 2018

We're waiting for the external containers to be published to gcr.io/ so we can update the E2E tests to point to them. Then this PR should be good to merge. Everything else is done.

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 16, 2018

@saad-ali is there a link to the PR to update the e2e test endpoints? And is there an ETA to when this is likely to merge?

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 16, 2018

No other PR, I will just push an update to this PR pointing to the new containers. Should be done in the next hour or two.

@saad-ali saad-ali force-pushed the saad-ali:updateCSI10 branch from 71ef08f to 874832a Nov 16, 2018

@saad-ali saad-ali force-pushed the saad-ali:updateCSI10 branch from 874832a to 503f654 Nov 16, 2018

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 16, 2018

Ok, all good to go.

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Nov 16, 2018

/lgtm

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 16, 2018

/hold cancel

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 16, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot k8s-ci-robot merged commit 6fc6042 into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation saad-ali authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment