Fixes flaky tests for kubectl port-forward #71048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
sig/testing
|
/test all |
k8s-ci-robot
added
size/L
m1kola
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/M
m1kola
commented
Nov 15, 2018
| defer func() { | ||
| logs, err := framework.GetPodLogs(f.ClientSet, f.Namespace.Name, pod.Name, "portforwardtester") | ||
| if err != nil { | ||
| framework.Logf("Error getting pod log: %v", err) |
There was a problem hiding this comment.
This (and similar code in other places) doesn't make much sense anymore, because in case of failure Gomega will print logs we are trying to match.
|
@seans3 could you, please, have a look? /assign seans3 |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1kola, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.13 |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 27, 2018
…-upstream-release-1.12 Automated cherry pick of #71048: Fixes flaky tests for kubectl port-forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
Fixes flaky tests like this:
Related to kubernetes/kubectl#558 (see "Flake 1")
Does this PR introduce a user-facing change?:
/sig cli