-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong log when do a rollback to a succeed rolling-update #71102
Conversation
Hi @zhangmingld. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhangmingld If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Please add a test for this to avoid falling back.
/test pull-kubernetes-e2e-kops-aws |
@dixudx i am a little confusing , you mean a e2e test ? |
@@ -356,6 +356,9 @@ func (o *RollingUpdateOptions) Run() error { | |||
|
|||
if o.Rollback { | |||
newName := o.FindNewName(oldRc) | |||
if len(newName) == 0 { | |||
return fmt.Errorf("Could not rollback a succeed roling-update or a non-rolling-update RC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct to change "roling-update" to "rolling-update"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou , i have changed it
37a4fde
to
50e6e40
Compare
/test pull-kubernetes-e2e-gce |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If user did a rollback to a succeed rolling-update RC
They will get the following:
[root@k8s-master:/home/ubuntu/cka]$ kubectl rolling-update rc-rool2 --rollback=true
error: Could not find to rollback.
after this pr
User will get the following
root@k8s-master:/home/ubuntu/cka]$ kubectl rolling-update rc-rool2 --rollback=true
error: Could not rollback a succeed roling-update or a non-rolling-update RC
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: