Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release note #71187

Merged
merged 1 commit into from
Nov 20, 2018
Merged

fix release note #71187

merged 1 commit into from
Nov 20, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 18, 2018 •
edited

Remove a release note for a reverted PR to avoid user confusion

/kind bug
/milestone v1.13
/priority critical-urgent
/sig release

(critical-urgent priority is to satisfy the bot)

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 18, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 18, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 18, 2018

/assign @smarterclayton

@AishSundar AishSundar mentioned this pull request Nov 18, 2018
Closed
@AishSundar
Copy link
Contributor

Seems to be hit by #71189

@liggitt
Copy link
Member Author

liggitt commented Nov 19, 2018

/retest

@smarterclayton
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit e20c151 into kubernetes:master Nov 20, 2018
@liggitt liggitt deleted the fix-release-note branch November 21, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @AishSundar @smarterclayton @k8s-ci-robot