Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace works about enable the ipvs mode for the kube-proxy by default #71202

Closed
6 tasks
Lion-Wei opened this issue Nov 19, 2018 · 34 comments
Closed
6 tasks

Trace works about enable the ipvs mode for the kube-proxy by default #71202

Lion-Wei opened this issue Nov 19, 2018 · 34 comments
Assignees
Labels
area/ipvs area/kube-proxy kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@Lion-Wei
Copy link

Lion-Wei commented Nov 19, 2018

This issue is to trace the works about make IPVS mode as kube-proxy default mode.
/kind feature

@luxas @timothysc @m1093782566 @bowei @caseydavenport @cmluciano , Please check.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 19, 2018
@Lion-Wei
Copy link
Author

/area ipvs
/sig network
/kind feature
/assign

@k8s-ci-robot k8s-ci-robot added area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 19, 2018
@m1093782566
Copy link
Contributor

cc @thockin @rramkumar1

@Lion-Wei
Copy link
Author

#68974 and #65820 are solved issue, so I didn't put them on the list, seems both those two issue can be closed. : )

@timothysc
Copy link
Member

Are you intending to target 1.14?

@uablrek
Copy link
Contributor

uablrek commented Nov 30, 2018

#71596 is related

@luxas
Copy link
Member

luxas commented Dec 4, 2018

Are you intending to target 1.14?

ping @Lion-Wei

@m1093782566
Copy link
Contributor

m1093782566 commented Dec 4, 2018 via email

@luxas luxas added this to the v1.14 milestone Dec 4, 2018
@luxas
Copy link
Member

luxas commented Dec 4, 2018

Ok. We need to extensively build out e2e testing for this then.

@luxas
Copy link
Member

luxas commented Dec 4, 2018

cc @kubernetes/sig-testing @kubernetes/sig-cluster-lifecycle @kubernetes/sig-network-feature-requests @kubernetes/sig-architecture-feature-requests for visibility, as this is significant

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Dec 4, 2018
@luxas
Copy link
Member

luxas commented Dec 4, 2018

IMO we need to create a new tracking issue in https://github.com/kubernetes/enhancements for this, and (maybe) a KEP how this transition will happen smoothly across all clusters, what the tradeoffs/migration steps are, etc.

@uablrek
Copy link
Contributor

uablrek commented Dec 4, 2018

If ipv6 is considered #65006 is related also, and hard to fix since the problem is in a vendor library.

@BenTheElder
Copy link
Member

not sure what coverage we have for this currently (had to track it all!), but we definitely need thorough e2e coverage if we're going to flip defaults. FYI @spiffxp

@m1093782566
Copy link
Contributor

m1093782566 commented Dec 5, 2018

There are already some test grids for IPVS proxier, they are running all network-sig e2e tests.

@dghubble
Copy link
Contributor

dghubble commented Dec 5, 2018

Some of the issues listed (in particular, not working with hostport #66103) have hindered adopting IPVS in clusters at all. Since these weren't included in GA, is there some other maturation window envisioned?

@justaugustus
Copy link
Member

Given @dghubble's feedback, I'd like to see a KEP for this that includes well-defined graduation criteria.

@luxas
Copy link
Member

luxas commented Dec 5, 2018

Yes, let's make sure we have an absolute 100% feature parity before we switch. Working with ipv6 going forward is also a necessity. A switch of a default is definitely KEP-worthy IMO, after seeing these comments.

@uablrek
Copy link
Contributor

uablrek commented Dec 5, 2018

In the ipv4/ipv6 dual-stack kep kubernetes/enhancements#648 ipvs support is still only "nice-to-have". If proxier ipvs is default one may have to "downgrade" to iptables to get dual stack.
IMO ipvs should be supported also for dual stack.

@Quentin-M
Copy link
Contributor

#71071

@luxas
Copy link
Member

luxas commented Dec 8, 2018

@uablrek Yes, but in ipv6-only cluster ipvs should still work out-of-the-box without a "downgrade" to iptables, right?

Also I noticed this fun thing that ipvs is marked as experimental still in the CLI:

--proxy-mode ProxyMode
    Which proxy mode to use: 'userspace' (older) or 'iptables' (faster) or 'ipvs' (experimental). If blank, use the best-available proxy (currently iptables).  If the iptables proxy is selected, regardless of how, but the system's kernel or iptables versions are insufficient, this always falls back to the userspace proxy.

@nikopen
Copy link
Contributor

nikopen commented Feb 27, 2019

Greetings!

🏔️ code freeze 🏔️ is coming in about 10 days, is this intented to be implemented in the following 2-3 weeks?

@m1093782566 @Lion-Wei

@soggiest
Copy link

soggiest commented Mar 7, 2019

Hello! Code freeze for 1.14 is coming up in 2 days. Will this be implemented in the next week? Or should we punt until 1.15?

@m1093782566 @Lion-Wei

@m1093782566
Copy link
Contributor

Sound fair, we can put it to 1.15 cycle.

@soggiest
Copy link

soggiest commented Mar 7, 2019

/milestone 1.15

@k8s-ci-robot
Copy link
Contributor

@soggiest: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soggiest
Copy link

soggiest commented Mar 7, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Mar 7, 2019
@thockin thockin added the triage/unresolved Indicates an issue that can not or will not be resolved. label Mar 8, 2019
@freehan freehan removed the triage/unresolved Indicates an issue that can not or will not be resolved. label Apr 4, 2019
@uablrek
Copy link
Contributor

uablrek commented May 4, 2019

It must be clearified that proxy-mode=ipvs does not work in an ipv6-only cluster.

The support for ipv6 in proxy-mode=ipvs is re-classified as a "feature" in #65006

@uablrek
Copy link
Contributor

uablrek commented May 4, 2019

@luxas

About #71202 (comment), apparently proxy-mode=ipvs was not intended to work with ipv6.

@dims
Copy link
Member

dims commented May 14, 2019

/remove-sig architecture

please re-tag arch if needed, looks like all items fall under sig-network

@k8s-ci-robot k8s-ci-robot removed the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label May 14, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2019
@neolit123
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 11, 2019
@rikatz
Copy link
Contributor

rikatz commented Mar 26, 2021

/area kube-proxy

@rikatz
Copy link
Contributor

rikatz commented Mar 26, 2021

So we've been discussing about the evolution of kube-proxy and the maintainability of the modes (IPtables, ipvs, and so on) and we've reached a consensus that we need to evolve the vendoring of kube-proxy logics, modules (also take a look at: https://github.com/kubernetes-sigs/kpng)

So right now, talking with other sig-network folks, (@thockin @aojea @jayunit100 @uablrek ) we think this is not a movement we want to do right now (defaulting to IPVS) so I'm closing this issue :)

Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@rikatz: Closing this issue.

In response to this:

So we've been discussing about the evolution of kube-proxy and the maintainability of the modes (IPtables, ipvs, and so on) and we've reached a consensus that we need to evolve the vendoring of kube-proxy logics, modules (also take a look at: https://github.com/kubernetes-sigs/kpng)

So right now, talking with other sig-network folks, (@thockin @aojea @jayunit100 @uablrek ) we think this is not a movement we want to do right now (defaulting to IPVS) so I'm closing this issue :)

Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipvs area/kube-proxy kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Development

No branches or pull requests