Introduce NodeKiller -- a utility to simulate node failures in e2e tests #71320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This PR contains draft of the change. Will update when it's ready for review. |
|
@mborsz - given that we would like to migrate to ClusterLoader hopefully really soon, we should consider integrating it with ClusterLoader instead, maybe? |
k8s-ci-robot
added
size/L
mborsz
force-pushed
the
nodekiller
branch
4 times, most recently
from
15aa6f5
to
33b309c
Compare
mborsz
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
I think it's ready for review. |
|
https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71320/pull-kubernetes-e2e-gce-100-performance/27969/ -- this is a gce-100-performance run with nodekiller enabled. |
mborsz
force-pushed
the
nodekiller
branch
2 times, most recently
from
f791f11
to
4d09199
Compare
mborsz
changed the title
mborsz
force-pushed
the
nodekiller
branch
2 times, most recently
from
59b9962
to
8f0a845
Compare
k8s-ci-robot
added
the
kind/flake
|
/assign @wojtek-t |
wojtek-t
reviewed
Nov 29, 2018
mborsz
force-pushed
the
nodekiller
branch
2 times, most recently
from
3a4830b
to
643e54c
Compare
wojtek-t
reviewed
Nov 29, 2018
k8s-ci-robot
added
size/M
|
PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mborsz
added a commit
to mborsz/perf-tests
that referenced
this pull request
Dec 19, 2018
This is basically copy-paste of kubernetes/kubernetes#71320. In the next step, once we migrate -killer job to clusterloader2, I will remove NodeKiller from kubernetes/kubernetes repo to remove duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
For purposes of scalability tests, we need to simulate node failures.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @wojtek-t