Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #70753, #70676 and #70971 upstream release 1.10 #71334

Merged
merged 4 commits into from
Dec 13, 2018
Merged

Automated cherry pick of #70753, #70676 and #70971 upstream release 1.10 #71334

merged 4 commits into from
Dec 13, 2018

Conversation

cheftako
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Cherry pick of #70753, #70676 and #70971 on release-1.11.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
#70753 fix healthz checkerNames test so that it tests against the expected output
#70676 add ability to disable health checks on kube-apiserver for healthz using query-params
#70971 Report KCM as unhealthy if leader election is wedged.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 22, 2018
@MaciekPytel
Copy link
Contributor

/retest

@MaciekPytel
Copy link
Contributor

@cheftako Can you look into test failures?

@cheftako
Report KCM as unhealthy if leader election is wedged. Feedback from l…
393fa06 
…avalamp and deads2k. Changed Check() logic to be central to LeaderElector. Further changes, especially cleaning up the test code.
@cheftako cheftako force-pushed the automated-cherry-pick-of-#71325-upstream-release-1.10 branch from d08e6db to 393fa06 Compare November 27, 2018 22:46
@cheftako
Copy link
Member Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2018
@cheftako
Copy link
Member Author

@MaciekPytel Sorry I somehow missed the commit for the 1.10 changes. Its in now.

@lavalamp
Copy link
Member

lavalamp commented Dec 4, 2018

Walter has convinced me that these fix a bug in controller-manager's /healthz (it could return healthy even if the process is totally wedged) and therefore a cherry-pick is warranted.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 12, 2018
@cheftako
Copy link
Member Author

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 15008f0 into kubernetes:release-1.10 Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@lavalamp lavalamp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cheftako @MaciekPytel @lavalamp @k8s-ci-robot @fejta-bot @logicalhan