-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #70753, #70676 and #70971 upstream release 1.10 #71334
Automated cherry pick of #70753, #70676 and #70971 upstream release 1.10 #71334
Conversation
/retest |
@cheftako Can you look into test failures? |
…avalamp and deads2k. Changed Check() logic to be central to LeaderElector. Further changes, especially cleaning up the test code.
d08e6db
to
393fa06
Compare
/sig api-machinery |
@MaciekPytel Sorry I somehow missed the commit for the 1.10 changes. Its in now. |
Walter has convinced me that these fix a bug in controller-manager's /healthz (it could return healthy even if the process is totally wedged) and therefore a cherry-pick is warranted. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Cherry pick of #70753, #70676 and #70971 on release-1.11.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):#70753 fix healthz checkerNames test so that it tests against the expected output
#70676 add ability to disable health checks on kube-apiserver for healthz using query-params
#70971 Report KCM as unhealthy if leader election is wedged.
Does this PR introduce a user-facing change?: