Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71419: Set deadline for returning backend error #71460

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Automated cherry pick of #71419: Set deadline for returning backend error #71460

merged 1 commit into from
Nov 27, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 27, 2018 •
edited

Cherry pick of #71419 on release-1.10.

#71419: Set deadline for returning backend error

Fixes an issue with stuck connections handling error responses

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 27, 2018

/kind bug
/priority important-soon
/sig api-machinery
/assign @sttts @MaciekPytel
/milestone v1.10

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Nov 27, 2018
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2018
@MaciekPytel
Copy link
Contributor

@liggitt Your release note won't show up in patch release notes. For automated cherry-picks release tooling only looks at the original PR, whatever you write on cherry-pick is ignored.

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 27, 2018
@sttts
Copy link
Contributor

sttts commented Nov 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 27, 2018

@liggitt Your release note won't show up in patch release notes. For automated cherry-picks release tooling only looks at the original PR, whatever you write on cherry-pick is ignored.

added a release note to the main PR. the bot still complains about no release note being on the cherry-pick PRs unless you add one to the pick PR description.

@k8s-ci-robot k8s-ci-robot merged commit 54d676b into kubernetes:release-1.10 Nov 27, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#71419-upstream-release-1.10 branch April 22, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sttts sttts

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @MaciekPytel @sttts