Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for cloudProvider.InstanceNotFound in Azure VMSS Instance gets #71597

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add check for cloudProvider.InstanceNotFound in Azure VMSS Instance gets #71597

merged 1 commit into from
Dec 4, 2018

Conversation

marc-sensenich
Copy link
Contributor

@marc-sensenich marc-sensenich commented Nov 30, 2018 •
edited

What type of PR is this?
/kind bug
/sig azure

What this PR does / why we need it:
Adds an additional error check when pulling a VMSS instance from the cache for the cloudprovider.InstanceNotFound error to allow for deletion of VMSS instances that have been removed from the cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #71595

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes an issue where Azure VMSS instances not existing in Azure were not being deleted by the Cloud Controller Manager.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @marc-sensenich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/azure and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 30, 2018
@marc-sensenich marc-sensenich changed the title WIP - Add additional err check for cloudProvider.InstanceNotFound error WIP - Add check for cloudProvider.InstanceNotFound in Azure VMSS Instance gets Nov 30, 2018
@marc-sensenich marc-sensenich changed the title WIP - Add check for cloudProvider.InstanceNotFound in Azure VMSS Instance gets Add check for cloudProvider.InstanceNotFound in Azure VMSS Instance gets Nov 30, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2018
feiskyer
feiskyer reviewed Dec 3, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-sensenich Thanks for the fix. LGTM

@feiskyer
Copy link
Member

feiskyer commented Dec 3, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2018
@feiskyer
Copy link
Member

feiskyer commented Dec 3, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 3, 2018
@feiskyer
Copy link
Member

feiskyer commented Dec 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@feiskyer
Copy link
Member

feiskyer commented Dec 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marc-sensenich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a605988 into kubernetes:master Dec 4, 2018
@marc-sensenich marc-sensenich mentioned this pull request Dec 5, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71756 from marc-sensenich/automated-cherry-pick-o…
72722ba 
…f-#71597-upstream-release-1.12

Automated cherry pick of #71597: Add additional err check for cloudProvider.InstanceNotFound
@marc-sensenich marc-sensenich deleted the gh-71595/fix-cloud-controller-manager-azure-delete-nodes branch January 11, 2019 13:05
@marc-sensenich marc-sensenich restored the gh-71595/fix-cloud-controller-manager-azure-delete-nodes branch January 11, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Controller Manager for Azure did not delete Scale Set instance
4 participants
@marc-sensenich @k8s-ci-robot @feiskyer @fejta-bot