Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71048: Fixes flaky tests for kubectl port-forward #71621

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Automated cherry pick of #71048: Fixes flaky tests for kubectl port-forward #71621

merged 1 commit into from
Dec 27, 2018

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 30, 2018 •
edited

Cherry pick of #71048 on release-1.12.

#71048: Fixes flaky tests for kubectl port-forward

NONE

/kind flake
/sig cli

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2018
@m1kola
Copy link
Member Author

m1kola commented Nov 30, 2018

We need to backport it into 1.12, because skew tests (we run them agains the 1.12 branch) are still failing sometimes.

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 30, 2018
@m1kola
Copy link
Member Author

m1kola commented Dec 1, 2018

Hi @soltysh and @seans3, could you, please, approve this cherry-pick of #71048 which you already approved? This is to fix flaky skew tests.

/assign @soltysh
/assign @seans3

dixudx
dixudx approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2018
@juanvallejo
Copy link
Contributor

cc @soltysh

soltysh
soltysh approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/assign @feiskyer
for 1.12 approval

@soltysh
Copy link
Contributor

soltysh commented Dec 20, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 20, 2018
@feiskyer
Copy link
Member

/retest

@m1kola
Copy link
Member Author

m1kola commented Dec 27, 2018

I think, this test failed because of a reason unrelated to this PR.

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 207cf13 into kubernetes:release-1.12 Dec 27, 2018
@m1kola m1kola deleted the automated-cherry-pick-of-#71048-upstream-release-1.12 branch December 27, 2018 11:22
@m1kola m1kola mentioned this pull request Dec 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dixudx dixudx dixudx approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

@feiskyer feiskyer

@dixudx dixudx

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@m1kola @juanvallejo @soltysh @k8s-ci-robot @feiskyer @dixudx @seans3