Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform #72772

lubinsz · 2019-01-10T09:40:26Z

Signed-off-by: Bin Lu bin.lu@arm.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We need to fix it so that we can install etcd on Arm64 platform.

Which issue(s) this PR fixes:

Special notes for your reviewer:
We can use it to install etcd for e2e test on Arm64 platform.

Does this PR introduce a user-facing change?:
NONE

NONE

k8s-ci-robot · 2019-01-10T09:40:33Z

Hi @lubinsz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lubinsz · 2019-01-10T09:54:21Z

/release-note-none

dims · 2019-01-10T14:25:54Z

hack/lib/etcd.sh

@@ -16,7 +16,7 @@

 # A set of helpers for starting/running etcd for tests

-ETCD_VERSION=${ETCD_VERSION:-3.2.18}
+ETCD_VERSION=${ETCD_VERSION:-3.3.10}


+1 as it matches what's in https://github.com/kubernetes/kubernetes/blob/master/build/root/WORKSPACE#L25

Looks like this was missed in #71615

dims · 2019-01-10T14:33:29Z

hack/lib/etcd.sh

      rm "${download_file}"
    fi
    kube::log::info "etcd v${ETCD_VERSION} installed. To use:"
    kube::log::info "export PATH=$(pwd)/etcd:\${PATH}"
+    if [[ ${arch_linux} != "amd64" ]]; then
+      kube::log::info "export ETCD_UNSUPPORTED_ARCH=${arch_linux}"


Looks like this is coming from https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/supported-platform.md#32-bit-and-other-unsupported-systems Right?

Can you please add a note for future?

dixudx · 2019-01-10T15:37:42Z

/ok-to-test

dixudx

lgtm overall.

lubinsz · 2019-01-11T04:59:47Z

/retest

lubinsz · 2019-01-11T05:32:51Z

/sig cluster-lifecycle

lubinsz · 2019-01-18T06:33:14Z

@dixudx @dims @BenTheElder
Hi all,
Any comments?

lubinsz · 2019-01-18T09:10:56Z

/retest

dixudx

/lgtm

BenTheElder · 2019-01-28T22:29:34Z

hack/lib/etcd.sh

    if [[ ${os} == "darwin" ]]; then
+      if [[ ${arch} != "amd64" ]]; then


do we actually need this check? how many darwin boxes aren't running amd64?

@BenTheElder Good point. I think this check is redundant.

@BenTheElder @dixudx Done.

Signed-off-by: Bin Lu <bin.lu@arm.com>

k8s-ci-robot · 2019-01-30T02:32:36Z

@lubinsz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	`5cdb762`	link	`/test pull-kubernetes-e2e-kops-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

BenTheElder

/lgtm

BenTheElder · 2019-02-15T03:26:22Z

/priority important-longterm

lubinsz · 2019-02-15T08:04:22Z

@dims @fejta @pwittrock
Can you approve it?
Thanks.

dims · 2019-02-15T11:36:09Z

/approve

k8s-ci-robot · 2019-02-15T11:36:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lubinsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2019

k8s-ci-robot requested review from juanvallejo and spiffxp January 10, 2019 09:41

lubinsz force-pushed the pr_etcd branch from 072cda6 to e20f087 Compare January 10, 2019 09:45

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 10, 2019

dims reviewed Jan 10, 2019

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2019

dixudx approved these changes Jan 10, 2019

View reviewed changes

lubinsz force-pushed the pr_etcd branch from e20f087 to 52b343d Compare January 11, 2019 03:07

k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 11, 2019

This was referenced Jan 11, 2019

add method to get host os/arch in hack scripts #72807

Merged

Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform #72804

Merged

lubinsz force-pushed the pr_etcd branch from 52b343d to 1e88a69 Compare January 18, 2019 05:28

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2019

dixudx approved these changes Jan 28, 2019

View reviewed changes

k8s-ci-robot assigned dixudx Jan 28, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019

BenTheElder reviewed Jan 28, 2019

View reviewed changes

Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform

5cdb762

Signed-off-by: Bin Lu <bin.lu@arm.com>

lubinsz force-pushed the pr_etcd branch from 1e88a69 to 5cdb762 Compare January 30, 2019 01:53

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019

k8s-ci-robot assigned BenTheElder Feb 15, 2019

BenTheElder approved these changes Feb 15, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019

k8s-ci-robot merged commit aeaeba4 into kubernetes:master Feb 15, 2019

lubinsz mentioned this pull request Jun 5, 2019

REQUEST: New membership for lubinsz kubernetes/org#887

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform #72772

Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform #72772

lubinsz commented Jan 10, 2019 •

edited

k8s-ci-robot commented Jan 10, 2019

lubinsz commented Jan 10, 2019

dims Jan 10, 2019

dims Jan 10, 2019

dims Jan 10, 2019

lubinsz Jan 11, 2019

dixudx commented Jan 10, 2019

dixudx left a comment

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 18, 2019

lubinsz commented Jan 18, 2019

dixudx left a comment

BenTheElder Jan 28, 2019

dixudx Jan 29, 2019

lubinsz Jan 30, 2019

k8s-ci-robot commented Jan 30, 2019

BenTheElder left a comment

BenTheElder commented Feb 15, 2019

lubinsz commented Feb 15, 2019 •

edited

dims commented Feb 15, 2019

k8s-ci-robot commented Feb 15, 2019

		if [[ ${os} == "darwin" ]]; then
		if [[ ${arch} != "amd64" ]]; then

Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform #72772

Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform #72772

Conversation

lubinsz commented Jan 10, 2019 • edited

k8s-ci-robot commented Jan 10, 2019

lubinsz commented Jan 10, 2019

dims Jan 10, 2019

Choose a reason for hiding this comment

dims Jan 10, 2019

Choose a reason for hiding this comment

dims Jan 10, 2019

Choose a reason for hiding this comment

lubinsz Jan 11, 2019

Choose a reason for hiding this comment

dixudx commented Jan 10, 2019

dixudx left a comment

Choose a reason for hiding this comment

lubinsz commented Jan 11, 2019

lubinsz commented Jan 11, 2019

lubinsz commented Jan 18, 2019

lubinsz commented Jan 18, 2019

dixudx left a comment

Choose a reason for hiding this comment

BenTheElder Jan 28, 2019

Choose a reason for hiding this comment

dixudx Jan 29, 2019

Choose a reason for hiding this comment

lubinsz Jan 30, 2019

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 30, 2019

BenTheElder left a comment

Choose a reason for hiding this comment

BenTheElder commented Feb 15, 2019

lubinsz commented Feb 15, 2019 • edited

dims commented Feb 15, 2019

k8s-ci-robot commented Feb 15, 2019

lubinsz commented Jan 10, 2019 •

edited

lubinsz commented Feb 15, 2019 •

edited