Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Makes UDP testing command more Windows friendly #72918

Merged
merged 1 commit into from
Jan 29, 2019
Merged

tests: Makes UDP testing command more Windows friendly #72918

merged 1 commit into from
Jan 29, 2019

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/kind failing-test
/sig testing
/sig windows

What this PR does / why we need it:

By default, cmd is used to execute commands in Windows containers, but it
has some issues executing the command (no output):

echo 'hostName' | nc -w 1 -u <targetIP> <targetPort>

But it has no issues running (output is correct):

echo hostName | nc -w 1 -u <targetIP> <targetPort>

This causes the test "should function for node-pod communication: udp" to
fail when using Windows Containers.

Which issue(s) this PR fixes:

Fixes #72917

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@claudiubelu
tests: Makes UDP testing command more Windows friendly
72be895 
By default, cmd is used to execute commands in Windows containers, but it
has some issues executing the command (no output):

echo 'hostName' | nc -w 1 -u <targetIP> <targetPort>

But it has no issues running (output is correct):

echo hostName | nc -w 1 -u <targetIP> <targetPort>

This causes the test "should function for node-pod communication: udp" to
fail when using Windows Containers.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @BCLAU. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2019
@claudiubelu
Copy link
Contributor Author

/assign @spiffxp

@yujuhong
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2019
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@benmoss benmoss mentioned this pull request Jan 15, 2019
Closed
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@oomichi
Copy link
Member

oomichi commented Jan 16, 2019

Does the line https://github.com/kubernetes/kubernetes/pull/72918/files#diff-cb4c40bc4199d52e8b5e9e7f26e84d91R311 returns some error on this issue?
If so, can we know what kind of error on that?

@claudiubelu
Copy link
Contributor Author

claudiubelu commented Jan 17, 2019 •
edited

@oomichi no, it does not, the output is just empty. This is also something I've tried out manually:

kubectl exec -n pod-network-test host-test-container-pod -- cmd /S /C "echo 'hostName' | nc -w 1 -u 10.240.0.134 8081"
(nothing)
kubectl exec -n pod-network-test host-test-container-pod -- cmd /S /C "echo hostName | nc -w 1 -u 10.240.0.134 8081"
netserver-0

@PatrickLang
Copy link
Contributor

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 23, 2019
neolit123
neolit123 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/framework/networking_utils.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2019
@neolit123
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 25, 2019
@michmike
Copy link
Contributor

/approve
/lgtm

@claudiubelu
Copy link
Contributor Author

/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Jan 25, 2019

/approve
wow, TIL, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, michmike, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@michmike
Copy link
Contributor

/test pull-kubernetes-e2e-gce

@neolit123
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PatrickLang PatrickLang added this to In Review in SIG-Windows Jan 29, 2019
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit d66db4a into kubernetes:master Jan 29, 2019
SIG-Windows automation moved this from In Review to Done (v.1.14) Jan 29, 2019
@claudiubelu claudiubelu deleted the tests/windows-cmd-fix branch April 19, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@michmike michmike michmike approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@spiffxp spiffxp

@neolit123 neolit123

@michmike michmike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

test fails due to command incompatible with Windows cmd
9 participants
@claudiubelu @k8s-ci-robot @yujuhong @oomichi @PatrickLang @neolit123 @michmike @spiffxp @fejta-bot