Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI: Pass namespace into to cri #73155

Closed
linxiulei opened this issue Jan 22, 2019 · 6 comments
Closed

CRI: Pass namespace into to cri #73155

linxiulei opened this issue Jan 22, 2019 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@linxiulei
Copy link
Contributor

What would you like to be added:

Pass namespace into to cri to let cri implement has the namespace context and then reinforce the isolation of data between namespaces

Why is this needed:

For instance of cri-containerd, which depends on containerd mechanism. We found there are several issues regarding image in containerd (containerd/containerd#2889). Long story short, every image kubernetes pulled can be accessed by any kubernetes user in certain way without authorization. It is because cri only use one namespace in containerd "k8s.io".

Therefore, passing namespace to cri enhances the isolation and security.
@linxiulei linxiulei added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 22, 2019
@linxiulei
Copy link
Contributor Author

/sig kubelet
/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2019
@linxiulei
Copy link
Contributor Author

/cc @Random-Liu

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Jan 30, 2019
@linxiulei
Pass namespace info to CRI
28794a5 
Pass namespace into to CRI to let CRI implement has a way to reenforce
isolation between namespaces.

This commit adds an extra argument(namespace) to every method which invokes
cri methods and GC thread would use empty namespace to get all container
data.

Fixes kubernetes#73155
@linxiulei linxiulei mentioned this issue Jan 30, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 29, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP]Pass namespace info to CRI linxiulei/kubernetes
3 participants
@linxiulei @k8s-ci-robot @fejta-bot