Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose preflight join as phases #73163

Merged
merged 1 commit into from
Jan 30, 2019
Merged

expose preflight join as phases #73163

merged 1 commit into from
Jan 30, 2019

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Jan 22, 2019 •
edited

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Refs kubernetes/kubeadm#1204

Does this PR introduce a user-facing change?:

-->

NONE

@fabriziopandini @ereslibre @neolit123 @yagonobre CC

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @MalloZup. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2019
yagonobre
yagonobre reviewed Jan 22, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MalloZup I'll take a look in a bit.
/ok-to-test
/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 22, 2019
@MalloZup
Copy link
Contributor Author

MalloZup commented Jan 22, 2019 •
edited

yop @yagonobre thx. take your time. 🌻 For me i think is important the first 2 points.

The rest i will need to work later. Imho, i'm stating that removing the pointers is more stable for our usecase. If we agree on that, i will send separate PR backporting the 2 comimits. ( and also as UX dev experience the phase interfaces would be aligned)

The 3rd point and the rest of PR is not crucial yet, and i will need to figure out later the small steps.

I think in best-approach i will send separate PR for fixing sub-issues (and rebasing this pr as mainline)

Also as reminder question for the 3rd point.

we all agree that kubeadm join phase preflight doesn't assume any other extra option like token etc as mandatory right? or i'm misunderstating some points? tia. 🤖

rosti
rosti reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MalloZup !
Looks nice for a start (apart from the obvious TODOs and no code removal of duplicated parts in runPreflightJoin - that's expected for a WIP PR).
Only tiny nits for now.

cmd/kubeadm/app/cmd/join.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/join.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
yagonobre
yagonobre reviewed Jan 22, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MalloZup can you run ./hack/update-bazel.sh?

cmd/kubeadm/app/cmd/join.go Show resolved Hide resolved
cmd/kubeadm/app/cmd/join.go Outdated Show resolved Hide resolved
@MalloZup MalloZup force-pushed the phases-preflight branch 2 times, most recently from 66353ba to 29d8f51 Compare January 22, 2019 17:33
@fabriziopandini
Copy link
Member

/assign

fabriziopandini
fabriziopandini reviewed Jan 23, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MalloZup Well done!
I think that we are already in a good shape!
I left some comments, nothing major, and there is one todo left to be addressed

cmd/kubeadm/app/cmd/join.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/config/joinconfiguration.go Outdated Show resolved Hide resolved
@MalloZup MalloZup changed the title expose preflight join as phases WI: expose preflight join as phases Jan 30, 2019
@MalloZup MalloZup changed the title WI: expose preflight join as phases WIP: expose preflight join as phases Jan 30, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2019
@MalloZup
Copy link
Contributor Author

@rosti @neolit123 @fabriziopandini @ereslibre feel free to review it again and i will squash commits at the end when it is ok

@MalloZup MalloZup changed the title WIP: expose preflight join as phases expose preflight join as phases Jan 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2019
@MalloZup
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

neolit123
neolit123 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the updates here @MalloZup ! this looks good.
/approve

leaving the LGTM to @fabriziopandini @ereslibre @yagonobre

@neolit123
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

@MalloZup: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws f8a17f91617222c5a099ad4e9a9951c09d852800 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fabriziopandini
fabriziopandini suggested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MalloZup
1 small point to be address + 1 nits then ready to approve & lgtm

cmd/kubeadm/app/cmd/phases/preflight.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/workflow/runner.go Outdated Show resolved Hide resolved
yagonobre
yagonobre reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MalloZup after you address all @fabriziopandini comments, LGTM :)

@ereslibre
Copy link
Contributor

Aside from minor nit LGTM, please update.

@MalloZup
Copy link
Contributor Author

thx updated 🚀

@MalloZup
Copy link
Contributor Author

rocket

@fabriziopandini
Copy link
Member

/lgtm
/approve

Great job! Let's keep this rolling!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MalloZup, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ereslibre
Copy link
Contributor

/lgtm

Thanks @MalloZup!

@k8s-ci-robot k8s-ci-robot merged commit f2ade8e into kubernetes:master Jan 30, 2019
This was referenced Feb 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre left review comments

@neolit123 neolit123 neolit123 approved these changes

@rosti rosti rosti requested changes

@yagonobre yagonobre yagonobre left review comments

@fabriziopandini fabriziopandini fabriziopandini requested changes

@liztio liztio Awaiting requested review from liztio

Assignees

@ereslibre ereslibre

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MalloZup @k8s-ci-robot @fabriziopandini @neolit123 @RA489 @rosti @ereslibre @yagonobre @timothysc