Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CoreDNS version to 1.3.1 #73610

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Bump CoreDNS version to 1.3.1 #73610

merged 1 commit into from
Feb 1, 2019

Conversation

rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Jan 31, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Bumps the CoreDNS version to 1.3.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS is now version 1.3.1
   - A new `k8s_external` plugin that allows external zones to point to Kubernetes in-cluster services.
   - CoreDNS now checks if a zone transfer is allowed. Also allow a TTL of 0 to avoid caching in the cache plugin.
   - TTL is also applied to negative responses (NXDOMAIN, etc).
   - Also provides a deprecation notice for `upstream` where the upstream directive used in various plugin will start to default to the CoreDNS process itself.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 31, 2019
@rajansandeep
Copy link
Contributor Author

/cc @neolit123

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2019
MrHohn
MrHohn approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2019
@MrHohn
Copy link
Member

MrHohn commented Jan 31, 2019

CoreDNS is now version 1.3.1

May be worth to update release note with what is new in version 1.3.1?

neolit123
neolit123 approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/priority important-longterm
@kubernetes/sig-cluster-lifecycle-pr-reviews

let's hold for a day to give time for others to see the change.
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 31, 2019
@neolit123
Copy link
Member

May be worth to update release note with what is new in version 1.3.1?

or at least an one line summary?

@rajansandeep
Copy link
Contributor Author

@MrHohn @neolit123 I've updated the release notes.

@neolit123
Copy link
Member

neolit123 commented Jan 31, 2019 •
edited

thanks @rajansandeep !
@MrHohn if the cluster folder needs this ASAP please feel free to hold cancel.

@MrHohn
Copy link
Member

MrHohn commented Jan 31, 2019

@MrHohn if the cluster folder needs this ASAP please free to hold cancel.

I don't think that is the case so let's wait a bit on this.

@fabriziopandini
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MrHohn, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

ok, let's unhold.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit b1eae78 into kubernetes:master Feb 1, 2019
@rajansandeep rajansandeep mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@MrHohn MrHohn MrHohn approved these changes

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@fabriziopandini fabriziopandini

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajansandeep @MrHohn @neolit123 @fabriziopandini @k8s-ci-robot