Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove very old debugging log lines that are no longer needed #73683

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Remove very old debugging log lines that are no longer needed #73683

merged 1 commit into from
Feb 4, 2019

Conversation

smarterclayton
Copy link
Contributor

When we originally added YAML guessing we had a reasonable concern
that we might get it wrong and need debugging. In the last 4 years
we have not yet had such a case, and v(4) often shows up in operator
style logs when it adds nothing.

Remove the lines.

/kind bug

NONE

@smarterclayton
Remove very old debugging log lines that are no longer needed
1e40f93 
When we originally added YAML guessing we had a reasonable concern
that we might get it wrong and need debugging. In the last 4 years
we have not yet had such a case, and v(4) often shows up in operator
style logs when it adds nothing.

Remove the lines.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2019
@dims
Copy link
Member

dims commented Feb 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2019
@nikopen
Copy link
Contributor

nikopen commented Feb 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1ff2809 into kubernetes:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@dims dims

@nikopen nikopen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smarterclayton @k8s-ci-robot @dims @nikopen