Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prettybench and go-junit-report to the vendor #73740

Merged
merged 3 commits into from
Feb 6, 2019

Conversation

krzysied
Copy link
Contributor

@krzysied krzysied commented Feb 5, 2019

What type of PR is this?
/kind flake

What this PR does / why we need it:
Adding github.com/cespare/prettybench and github.com/jstemmer/go-junit-report to the vendor. Testing script wills install prettybench and go-junit-report from vendor instead of downloading them.

Will fix possible flakes caused by downloading code.

Which issue(s) this PR fixes:

ref #73581 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/priority important-soon
/sig testing

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2019
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 5, 2019
@krzysied
Copy link
Contributor Author

krzysied commented Feb 5, 2019

/assign @fejta

@fejta
Copy link
Contributor

fejta commented Feb 5, 2019

/lgtm

Thanks for doing this, it will make our builds more stable by go installed vendored code rather than fetching it off the network each build:

/assign @cblecker @thockin @sttts
This is for #73581, please review for approval!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@thockin
Copy link
Member

thockin commented Feb 6, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 04cc8f6 into kubernetes:master Feb 6, 2019
@krzysied krzysied deleted the prettybench_vendor branch February 6, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants