Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CRD column printers consistent with typed printers #73888

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Make CRD column printers consistent with typed printers #73888

merged 1 commit into from
Feb 10, 2019

Conversation

smarterclayton
Copy link
Contributor

Almost all other server side printers use duration.HumanDuration
which has higher precision output. Switch CRD printers to use this
as well.

/kind bug

NONE

@smarterclayton
Make CRD column printers consistent with typed printers
6b1a510 
Almost all other server side printers use duration.HumanDuration
which has higher precision output. Switch CRD printers to use this
as well.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2019
@dims
Copy link
Member

dims commented Feb 10, 2019

Simple enough change for me to lgtm :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3dfb9e8 into kubernetes:master Feb 10, 2019
@logicalhan
Copy link
Member

/cc @mbohlool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo Awaiting requested review from janetkuo

@liggitt liggitt Awaiting requested review from liggitt

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smarterclayton @k8s-ci-robot @dims @logicalhan