Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generated_files: remove line about /docs/.generated_docs (fix PR size plugin) #73893

Merged
merged 1 commit into from
Feb 11, 2019
Merged

generated_files: remove line about /docs/.generated_docs (fix PR size plugin) #73893

merged 1 commit into from
Feb 11, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Feb 11, 2019 •
edited

What this PR does / why we need it:

after #70052 was merged @cjwagner found that a certain line in /.generated_files has to be removed too:
#70052 (comment)

remove the line in question.

Until this is merged the size plugin will fail to apply and update size/* labels on all PRs in the k/k repo.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

/cc @cjwagner @spiffxp
/kind cleanup
/kind failing-test
/priority important-longterm
/sig testing

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 11, 2019
@neolit123
Copy link
Member Author

/assign @dchen1107

cjwagner
cjwagner approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Until this is merged the size plugin will fail to apply and update size/* labels on all PRs in the k/k repo.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2019
@neolit123 neolit123 changed the title generated_files: remove line about /docs/.generated_docs generated_files: remove line about /docs/.generated_docs (fix PR size plugin) Feb 11, 2019
@neolit123
Copy link
Member Author

/remove-kind failing-test
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Feb 11, 2019
@dims
Copy link
Member

dims commented Feb 11, 2019

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 836db5c into kubernetes:master Feb 11, 2019
@cjwagner
Copy link
Member

size/* labels are being applied again (e.g. #73650 (comment))

Thanks all!

@neolit123
Copy link
Member Author

nice!
thanks @cjwagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@liggitt liggitt

@cjwagner cjwagner

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@neolit123 @dims @liggitt @k8s-ci-robot @cjwagner @dchen1107