-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup in topology.go #74016
Cleanup in topology.go #74016
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @ahadas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Trying to resolve the CLA issue |
71b8f18
to
7bc8f9c
Compare
7bc8f9c
to
80b15e4
Compare
/ok-to-test |
Seems I've been added to the group of Authorized CNCF Contributors (Red Hat) |
1. Find the minimal thread number within a core using a single loop rather than by sorting the thread numbers. 2. Inline getUniqueCoreID#err and Discover#numCPUs variables. 3. Narrow the scope of Discover#coreID and Discover#err variables. Signed-off-by: Arik Hadas <ahadas@redhat.com>
80b15e4
to
c3a533e
Compare
/assign @derekwaynecarr |
/assign @vishh @ConnorDoyle @sjenning @balajismaniam |
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahadas, ConnorDoyle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
single loop rather than by sorting the thread numbers.
Does this PR introduce a user-facing change?: