Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shellcheck in test/e2e_node/jenkins/... #74488

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix shellcheck in test/e2e_node/jenkins/... #74488

merged 1 commit into from
Mar 1, 2019

Conversation

xichengliudui
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 25, 2019
xichengliudui
xichengliudui commented Feb 25, 2019
View reviewed changes
test/e2e_node/jenkins/conformance/conformance-jenkins.sh
@@ -22,15 +22,15 @@ set -x

: "${1:?Usage test/e2e_node/jenkins/conformance-node-jenkins.sh <path to properties>}"

. $1
. "${1}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change:

In ./test/e2e_node/jenkins/conformance/conformance-jenkins.sh line 25:
. $1
  ^-- SC2086: Double quote to prevent globbing and word splitting.

test/e2e_node/jenkins/ubuntu-14.04-nvidia-install.sh Outdated
@@ -23,7 +23,7 @@ if ! dpkg-query -W cuda; then
dpkg -i ./cuda-repo-ubuntu1404_8.0.61-1_amd64.deb
apt-get update
apt-get install cuda -y
apt-get install linux-headers-$(uname -r) -y
apt-get install linux-headers-"$(uname -r)" -y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change:

In ./test/e2e_node/jenkins/ubuntu-14.04-nvidia-install.sh line 26:
  apt-get install linux-headers-$(uname -r) -y
                                ^---------^ SC2046: Quote this to prevent word splitting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually quote the whole string:

Suggested change
apt-get install linux-headers-"$(uname -r)" -y
apt-get install "linux-headers-$(uname -r)" -y

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified

@xichengliudui
Copy link
Contributor Author

/assign @dashpole @BenTheElder

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@xichengliudui
Copy link
Contributor Author

@BenTheElder

@BenTheElder
Copy link
Member

one minor nit, generally looks good, thank you!

BenTheElder
BenTheElder approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@xichengliudui
Copy link
Contributor Author

/assign @shashidharatd

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 26, 2019
BenTheElder
BenTheElder approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xichengliudui
Copy link
Contributor Author

/assign @fejta

@BenTheElder
Copy link
Member

BenTheElder commented Mar 1, 2019 •
edited

/assign @dims
dims: IMO you should remove the comment from your hack/OWNERS entry 🙃

@dims
Copy link
Member

dims commented Mar 1, 2019

/approve
/lgtm

@BenTheElder the comment from your hack/OWNER gives me plausible deniability :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8acb522 into kubernetes:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@tmrts tmrts Awaiting requested review from tmrts

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@dims dims

@BenTheElder BenTheElder

@fejta fejta

@dashpole dashpole

@shashidharatd shashidharatd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@xichengliudui @dashpole @BenTheElder @dims @k8s-ci-robot @fejta-bot @fejta @shashidharatd