Eliminate shellcheck failures #72956
Comments
k8s-ci-robot
added
the
sig/testing
|
@spiffxp I am tackling this optimistically for 1.14, but I could see it slipping to 1.15 depending on time-to-review, bandwidth, etc.. |
|
/priority important-longterm |
k8s-ci-robot
added
the
priority/important-longterm
|
/milestone v1.14 |
|
@BenTheElder would it be ok if I helped out with this? I was thinking I could go through and cover the scripts in |
|
That would be great! there's a lot to tackle here 😅 If you could reference this issue (just include a link somewhere, please don't mark it as "fixes #" 🙃) that would be helpful for attempting to avoid overlap :-) |
|
@BenTheElder |
|
Go for it! 🙂
We might even want multiple PRs for that one - If I remember correctly,
there was plenty to fix in that one 😛
…On Sun, Jan 20, 2019, 15:07 Kartik Yadav ***@***.*** wrote:
@BenTheElder <https://github.com/BenTheElder>
Can I help with ./build/common.sh
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72956 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4BqwY2Ny9UJxZ9htOYQYpUBnuy9XNnks5vFPakgaJpZM4aClvY>
.
|
|
I will fix |
|
I'll work on the scripts in |
|
I will fix |
|
I will fix |
|
Hey 👋 Bug Triage here. Wanted to follow up on the status of this issue as we're approaching code freeze on 12.11.2020. This issue is tagged for 1.20, is it still planned for this release? |
|
Current status is (still) 3 remaining (although a handful of the sub-PRs for cluster/gce/util.sh have been merged): ./cluster/gce/gci/configure.sh #90442 (all tests passed, ready for jay or nay) |
|
I have now created #95865 which is bringing @gavinfish's closed-due-to-inactivity #88582 back to life with a few updates. With that one, the lineup of active ongoings would look like: ./cluster/gce/gci/configure.sh #90442 (all tests passed, ready for jay or nay) |
|
👋 Hi, Bug Triage here, we're pretty late into the code freeze for 1.20 - I am going to put this in the 1.21 milestone /milestone v1.21 |
|
Since I just did this out of curiousity for hack/.golint_failures... There have been 258 commits that touched
|
|
So close now! Getting there... |
The sub-PRs #94456 #94459 #94463 are now merged and the size of changes that remain in #90405 significantly decreased. |
|
I think we should be landing these soon, well within 1.21. Then we can follow up with making the verify-shellcheck script much simpler and faster (by not supporting known failures). Updated the checklist again, looking at outstanding PRs. |
|
still may hit some test flakes, but I believe the remaining fixes are all LGTM+approve. |
|
Joy to the world, all fixes for cluster/gce/util.sh (#90405) are finally in place! |
|
And BAM now #90442 is also merged, leaving |
|
#99816 removes the * unless someone really needs to ignore something and adds a Thank you so much all! |
|
xref: https://kubernetes.slack.com/archives/C92G08FGD/p1614915017006400 - thank you! |
and others
What happened: After #24614 / #68438 we had 283 known failing
*.shfiles being excluded from shellcheck lints.What you expected to happen: We should be linting all files. When files are listed in
hack/.shellcheck_failureswe may miss actual bugs in them. Initially to get the linter in place we had to list many files there to keep the PR reasonably sized, but ideally we can fix these over time and eliminate this file.How to reproduce it (as minimally and precisely as possible):
hack/verify-shellcheck.shAnything else we need to know?: I intend to continue working on this, EG #72861, #72955, ...
/sig testing
/assign
Known failing files TODO:
The text was updated successfully, but these errors were encountered: