-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parse devicePath issue on Azure Disk #74499
fix parse devicePath issue on Azure Disk #74499
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@feiskyer PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add unit tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
…4499-upstream-release-1.13 Automated cherry pick of #74499: fix parse devicePath issue on Azure Disk
…4499-upstream-release-1.11 Automated cherry pick of #74499: fix parse devicePath issue on Azure Disk
…4499-upstream-release-1.12 Automated cherry pick of #74499: fix parse devicePath issue on Azure Disk
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix parse devicePath issue on Azure Disk
There is some corner case that after attaching an Azure disk, disk device path is not displayed immediately under
/dev/disk/azure/scsi1/lun?
, instead it returns like/dev/sd?
, which will make disk mount failure(like below failure), this PR also handles such corner case, if failed, it logs the error and then use azure API(diskController.GetDiskLun
) to get disk LUN of that disk.As I could observe, in VMSS, disk detection after disk attachment is slow, sometimes user would get below error, workaround is delete the pod and let k8s remount.
Which issue(s) this PR fixes:
Fixes #74421
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/kind bug
/assign @feiskyer
/priority important-soon
/sig azure
cc @khenidak