CRD openapi v3 -> v2 conversion #74778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k/k#71137:
- apiextensions: prune {any,one}Of + Not recursively on OpenAPI v2 conversion
#6:
- apiextensions: filter CRD schema to not break (too) strict kube-openapi
- model validator;
- SQUASH: fix root level filtering to not drop properties;
- SQUASH: fix incomplete test specs which degenerate during kubectl <= 1.13 filtering
Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/XXL
|
/area custom-resources |
k8s-ci-robot
added
area/custom-resources
and removed
area/release-eng
|
/retest |
k8s-ci-robot
added
the
area/release-eng
k8s-ci-robot
removed
the
needs-kind
sttts
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conversion for CRD openapi v3 schema -> v2 schema, which is compatible with too-strict kube-openapi validator. Heavy lifting done by @sttts who deserves most credits here
prerequisite for #71192. Separating out for better review
/cc @liggitt @mbohlool @sttts
Does this PR introduce a user-facing change?: