Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72738: DaemonSet e2e: Update image and rolling upgrade test timeout #74820

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Automated cherry pick of #72738: DaemonSet e2e: Update image and rolling upgrade test timeout #74820

merged 1 commit into from
Mar 6, 2019

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Mar 1, 2019 •
edited

Automated cherry pick of #72738 upstream release 1.12

#72738: Fix conformance test for DaemonSet RollingUpdate which is too rigid on timeout

@alexbrand @janetkuo
DaemonSet e2e: Update image and rolling upgrade test timeout
3687f55 
Use Nginx as the DaemonSet image instead of the ServeHostname image.
This was changed because the ServeHostname has a sleep after terminating
which makes it incompatible with the DaemonSet Rolling Upgrade e2e test.

In addition, make the DaemonSet Rolling Upgrade e2e test timeout a
function of the number of nodes that make up the cluster. This is
required because the more nodes there are, the longer the time it will
take to complete a rolling upgrade.

Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@janetkuo janetkuo added this to the v1.12 milestone Mar 1, 2019
@k8s-ci-robot
Copy link
Contributor

@janetkuo: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2019
@janetkuo janetkuo added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 1, 2019
@janetkuo janetkuo changed the title DaemonSet e2e: Update image and rolling upgrade test timeout Automated cherry pick of #72738 upstream release 1.12: DaemonSet e2e: Update image and rolling upgrade test timeout Mar 1, 2019
@janetkuo janetkuo changed the title Automated cherry pick of #72738 upstream release 1.12: DaemonSet e2e: Update image and rolling upgrade test timeout Automated cherry pick of #72738: DaemonSet e2e: Update image and rolling upgrade test timeout Mar 1, 2019
@janetkuo
Copy link
Member Author

janetkuo commented Mar 1, 2019

Assigning patch release manager

/assign @feiskyer

@janetkuo janetkuo mentioned this pull request Mar 1, 2019
Merged
@janetkuo
Copy link
Member Author

janetkuo commented Mar 3, 2019

/test pull-kubernetes-verify

@janetkuo janetkuo added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 3, 2019
@feiskyer feiskyer added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 4, 2019
@feiskyer feiskyer removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 4, 2019
@janetkuo
Copy link
Member Author

janetkuo commented Mar 5, 2019

@tnozicka would you take a look? Thanks!

tnozicka
tnozicka approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 657a540 into kubernetes:release-1.12 Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@feiskyer feiskyer

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@janetkuo @k8s-ci-robot @fejta-bot @tnozicka @feiskyer @alexbrand