Adding a check to make sure Metadata is read only if flag value is true.

[rjaini]

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix kubelet start issue on Azure Stack.

Which issue(s) this PR fixes:
Fixes #74785
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Fix kubelet start failure issue on Azure Stack due to InstanceMetadata setting

/kind bug
/assign @feiskyer
cc @hongbin

[k8s-ci-robot]

Hi @rjaini. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[andyzhangx]

/ok-to-test
/sig azure
/priority important-soon

[andyzhangx]

/release-note "Fix kubelet start failure issue on Azure Stack due to InstanceMetadata setting"

[andyzhangx]

Hi @rjaini , would you sign the CLA first? we are close to code freeze time on k8s 1.14 soon.

[feiskyer]

Please also fix the panic in unit tests.

[feiskyer]

Let's add this into v1.14 milestone since it's a critical fix for AzureStack.

/milestone v1.14

[rjaini]

/test pull-kubernetes-bazel-test

[andyzhangx]

/lgtm

[andyzhangx]

@feiskyer PTAL, also. I can cherry pick this PR to older version when it's merged.

[andyzhangx]

@rjaini thanks for your contribution, just let us know if there is sth broken on Azure stack in the future.

[feiskyer]

lgtm, please squash the commits.

[justaugustus]

@rjaini -- Please add a release note to this PR. You can see how to do that here: https://git.k8s.io/community/contributors/guide/release-notes.md

@andyzhangx suggested the following: Fix kubelet start failure issue on Azure Stack due to InstanceMetadata setting.

Please also squash your commits.

[andyzhangx]

/release-note "Fix kubelet start failure issue on Azure Stack due to InstanceMetadata setting"

[rjaini]

Squash all commits.
@andyzhangx You can merge the commit.

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, rjaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/azure/OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

@rjaini Added the release note for you. The template in PR body should be used.

[justaugustus]

(waking up the bots)
/joke

[k8s-ci-robot]

@justaugustus: A red and a blue ship have just collided in the Caribbean. Apparently the survivors are marooned.

In response to this:

(waking up the boots)
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.