bindata in external bazel repository

[mariusgrigoriu]

e2e tests cannot be linked as an external bazel respository without some patching because bindata is generated with a prefix such as external/io_k8s_kubernetes.

We internally patch as follows, but I'm hoping we can upstream something more robust:

diff --git a/build/bindata.bzl b/build/bindata.bzl
index f21f42e577..28c0ef2df4 100644
--- a/build/bindata.bzl
+++ b/build/bindata.bzl
@@ -36,7 +36,7 @@ def go_bindata(
     outs = outs,
     cmd = """
     $(location //vendor/github.com/jteeuwen/go-bindata/go-bindata:go-bindata) \
-      -o "$@" -pkg %s -prefix $$(pwd) %s $(SRCS)
+      -o "$@" -pkg %s -prefix external/io_k8s_kubernetes %s $(SRCS)
     """ % (pkg, " ".join(args)),
     tools = [
       "//vendor/github.com/jteeuwen/go-bindata/go-bindata",

Has anyone considered using the bindata rules from rules_go? https://github.com/bazelbuild/rules_go/blob/master/extras/bindata.bzl

[mariusgrigoriu]

@kubernetes/sig-testing-proposals

[k8s-ci-robot]

@mariusgrigoriu: Reiterating the mentions to trigger a notification:
@kubernetes/sig-testing-proposals

In response to this:

@kubernetes/sig-testing-proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.