Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format error in CHANGELOG-1.14.md #75543

Merged
merged 1 commit into from
May 22, 2019
Merged

format error in CHANGELOG-1.14.md #75543

merged 1 commit into from
May 22, 2019

Conversation

qingsenLi
Copy link

@qingsenLi qingsenLi commented Mar 21, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

/sig release
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @qingsenLi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2019
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2019
neolit123
neolit123 reviewed Mar 21, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2019
@neolit123
Copy link
Member

@qingsenLi
this is also a problem in the release-1.14 branch:
https://github.com/kubernetes/kubernetes/blob/release-1.14/CHANGELOG-1.14.md#apply-resources-from-a-directory-containing-kustomizationyaml-74140-liujingfang1

please send a cherry pick of this PR to that branch. here is info how:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#initiate-a-cherry-pick

thanks.

@neolit123
Copy link
Member

/milestone v1.14
/assign @dstrebel @jeefy

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 21, 2019
neolit123
neolit123 reviewed Mar 21, 2019
View reviewed changes
CHANGELOG-1.14.md Outdated
@@ -272,7 +272,7 @@ filename | sha512 hash
* While this is a backwards-incompatible change, it would have been impossible to setup reliable monitoring around these metrics since the labels were not stable.
* Add a configuration field to shorten the timeout of validating/mutating admission webhook call. The timeout value must be between 1 and 30 seconds. Default to 30 seconds when unspecified. ([#74562](https://github.com/kubernetes/kubernetes/pull/74562), [@roycaihw](https://github.com/roycaihw))
* client-go: PortForwarder.GetPorts() now contain correct local port if no local port was initially specified when setting up the port forwarder ([#73676](https://github.com/kubernetes/kubernetes/pull/73676), [@martin-helmich](https://github.com/martin-helmich))
* # Apply resources from a directory containing kustomization.yaml ([#74140](https://github.com/kubernetes/kubernetes/pull/74140), [@Liujingfang1](https://github.com/Liujingfang1))
* Apply resources from a directory containing kustomization.yaml ([#74140](https://github.com/kubernetes/kubernetes/pull/74140), [@Liujingfang1](https://github.com/Liujingfang1))
* kubectl apply -k dir
* # Delete resources from a directory containing kustomization.yaml.
Copy link
Member

@neolit123 neolit123 Mar 21, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

the whole block needs to be formatted better:

# Apply resources from a directory containing kustomization.yaml
kubectl apply -k dir

# Delete resources from a directory containing kustomization.yaml.
kubectl delete -k dir

# List resources from a directory containing kustomization.yaml
kubectl get -k dir

i.e. not using bullets * (see the markdown preview).

@qingsenLi
Copy link
Author

/cc @neolit123 @tpepper
I fix it,how about this:
2019-03-22_110718

spiffxp
spiffxp reviewed Mar 22, 2019
View reviewed changes
CHANGELOG-1.14.md Outdated
* # List resources from a directory containing kustomization.yaml
* kubectl get -k dir
* The examples in kubectl apply/get/delete are updated to support -k. ([#74140](https://github.com/kubernetes/kubernetes/pull/74140), [@Liujingfang1](https://github.com/Liujingfang1))
* `kubectl apply -k dir` # Apply resources from a directory containing kustomization.yaml.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the "title" / one-line sentence is the only that should show up in these change log entries. I've edited the release notes block for #74140 accordingly

@spiffxp
Copy link
Member

spiffxp commented Mar 22, 2019

/cc @jeefy @dstrebel @onyiny-ang
I'm not sure there is much point to updating this file right now, it's ultimately going to get replaced by the release notes currently being worked on by the v1.14 release notes team

@spiffxp
Copy link
Member

spiffxp commented Mar 22, 2019

/hold

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2019
@qingsenLi
Copy link
Author

/retest

@qingsenLi
Copy link
Author

/cc @jeefy @dstrebel @onyiny-ang
I updated the PR，followed #74140

@spiffxp
Copy link
Member

spiffxp commented Apr 19, 2019

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 19, 2019
@justaugustus justaugustus added this to Backlog in SIG Release Apr 28, 2019
@qingsenLi
Copy link
Author

/assign @smarterclayton @liggitt

@liggitt
Copy link
Member

liggitt commented May 21, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, qingsenLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1c10061 into kubernetes:master May 22, 2019
SIG Release automation moved this from Backlog to Done May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@jbeda jbeda Awaiting requested review from jbeda

@thockin thockin Awaiting requested review from thockin

@neolit123 neolit123 Awaiting requested review from neolit123

@tpepper tpepper Awaiting requested review from tpepper

@dstrebel dstrebel Awaiting requested review from dstrebel

@jeefy jeefy Awaiting requested review from jeefy

@onyiny-ang onyiny-ang Awaiting requested review from onyiny-ang

Assignees

@spiffxp spiffxp

@neolit123 neolit123

@liggitt liggitt

@smarterclayton smarterclayton

@jeefy jeefy

@dstrebel dstrebel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@qingsenLi @k8s-ci-robot @neolit123 @spiffxp @liggitt @fejta-bot @smarterclayton @jeefy @dstrebel