Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operation name for other volume operations #75926

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Add operation name for other volume operations #75926

merged 1 commit into from
Apr 18, 2019

Conversation

cwdsuzhou
Copy link
Member

@cwdsuzhou cwdsuzhou commented Mar 31, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature
/kind bug

What this PR does / why we need it:
Though, this pr allows different operation names of the same pod and volume, currently this is only effective for mount, unmount. Other volume operations' names have not been set.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 31, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @cwdsuzhou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 31, 2019
@cwdsuzhou
Copy link
Member Author

/assign @gnufied

@cwdsuzhou
Copy link
Member Author

@gnufied @jingxu97 @rootfs

PTAL

@gnufied
Copy link
Member

gnufied commented Apr 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2019
@cwdsuzhou
Copy link
Member Author

/retest

1 similar comment
@cwdsuzhou
Copy link
Member Author

/retest

@cwdsuzhou
Copy link
Member Author

/assign @saad-ali

@gnufied
Copy link
Member

gnufied commented Apr 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@cwdsuzhou
Copy link
Member Author

ping @saad-ali for approve

@cwdsuzhou
Copy link
Member Author

Thanks @gnufied

And could anyone help review it again or approve it @jingxu97 @rootfs

@cwdsuzhou cwdsuzhou force-pushed the operation_generator_add_attach_detach branch from a511174 to 7c9e567 Compare April 12, 2019 03:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2019
@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

2 similar comments
@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

ping @gnufied @saad-ali

PTAL again

@gnufied
Copy link
Member

gnufied commented Apr 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwdsuzhou, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@cwdsuzhou
Copy link
Member Author

Thanks @gnufied , could you add LGTM since I have changed the PR

@gnufied
Copy link
Member

gnufied commented Apr 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e02769 into kubernetes:master Apr 18, 2019
@cwdsuzhou cwdsuzhou deleted the operation_generator_add_attach_detach branch April 18, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali requested changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@gnufied gnufied

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cwdsuzhou @k8s-ci-robot @gnufied @saad-ali