Fix CRD validation error on 'items' field #76124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
tossmilestone
force-pushed
the
fix-crd-validate-items
branch
from
5333e76
to
16ed9f3
Compare
k8s-ci-robot
added
size/L
|
/assign @liggitt |
tossmilestone
force-pushed
the
fix-crd-validate-items
branch
from
16ed9f3
to
050d4c5
Compare
k8s-ci-robot
added
area/apiserver
sig/cli
tossmilestone
force-pushed
the
fix-crd-validate-items
branch
2 times, most recently
from
8dfb907
to
1403ba2
Compare
k8s-ci-robot
added
size/XL
|
@liggitt this PR is done now, PTAL. |
|
thanks for the quick update. the dependencies you pulled in have transitive dependencies we need to also bump. |
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
|
@liggitt all bumps are done, please check again. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
liggitt
reviewed
Jun 27, 2019
| @@ -349,9 +303,15 @@ func (s *Schema) AddType(tpe, format string) *Schema { | |||
| return s | |||
| } | |||
|
|
|||
| // AsNullable flags this schema as nullable. | |||
| func (s *Schema) AsNullable() *Schema { | |||
There was a problem hiding this comment.
@sttts, fyi that we picked up a version with this
|
@tossmilestone, thanks for all the work on this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tossmilestone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
liggitt
moved this from Required for GA, in progress
to Complete
in Custom Resource Definitions
This was referenced Oct 10, 2019
|
Unfortunately this fix has not solved the core issue. See go-openapi/validate#108 |
|
On further investigation I think this is due to See #83778 |
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
…te-items Fix CRD validation error on 'items' field Kubernetes-commit: 1a80962
aiyengar2
added a commit
to aiyengar2/charts
that referenced
this pull request
Oct 13, 2020
Root cause of the issue is that k8s 1.15 / 1.16 clusters seem to have known issues related to CRD fields that invoke `items` in it, such as the `volumes` we introduced as part of the nginx proxy that sits in front of Prometheus in Monitoring V2. This only seems to have been fixed in k8s 1.17+. More context: kubernetes/kubernetes#68466 is an issue that tracks a problem with CRDs that use fields named `items` introduced sometime before k8s 1.16. In k8s 1.16's release notes, this issue seemed to have been resolved as it shows up under `Other Notable Changes` [here](https://v1-16.docs.kubernetes.io/docs/setup/release/notes/#other-notable-changes-7): ``` Fix CRD validation error on ‘items’ field. (#76124, @tossmilestone) ``` However, when looking into the actual [PR](kubernetes/kubernetes#76124) that was executed to fix this issue, it seems like this issue had a followup in kubernetes/kubernetes#85223 that was only resolved in k8s 1.17+. This shows up in the k8s 1.17 release notes under `API Machinery` [here](https://v1-17.docs.kubernetes.io/docs/setup/release/notes/#api-machinery): ``` CRDs can have fields named type with value array and nested array with items fields without validation to fall over this. (#85223, @sttts) ``` Therefore, the quick fix was to just modify the contents provided to the `volumes` field of the `prometheusSpec`; once modified, Monitoring V2 successfully deployed in a k8s 1.16 cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: He Xiaoxi tossmilestone@gmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix CRD validation errror on 'items' field
Which issue(s) this PR fixes:
Fixes #68466
Special notes for your reviewer:
Does this PR introduce a user-facing change?: