Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some shellcheck failures of cluster/*.sh #76152

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Fix some shellcheck failures of cluster/*.sh #76152

merged 1 commit into from
Apr 20, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 4, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix some shellcheck failures of cluster/*.sh

Which issue(s) this PR fixes:

Ref #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 4, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 8, 2019

/test pull-kubernetes-e2e-gce

@k-toyoda-pi
Copy link
Contributor

Is it not necessary to remove fixed files from hack/.shellcheck_failuers?

@SataQiu
Copy link
Member Author

SataQiu commented Apr 12, 2019

@k-toyoda-pi
Not yet, because this PR only fixes some common problems of these scripts.
Additional PRs are required for further cleanup.

@k-toyoda-pi k-toyoda-pi mentioned this pull request Apr 12, 2019
Closed
@SataQiu
Copy link
Member Author

SataQiu commented Apr 14, 2019

/assign @mikedanese

@Katharine
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 17, 2019

/assign @jbeda

@SataQiu
Copy link
Member Author

SataQiu commented Apr 17, 2019

/assign @spiffxp

@SataQiu
Copy link
Member Author

SataQiu commented Apr 18, 2019

/assign @BenTheElder

BenTheElder
BenTheElder approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@spiffxp
Copy link
Member

spiffxp commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, SataQiu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 31903e6 into kubernetes:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@jbeda jbeda Awaiting requested review from jbeda

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@jbeda jbeda

@spiffxp spiffxp

@Katharine Katharine

@BenTheElder BenTheElder

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SataQiu @k-toyoda-pi @Katharine @spiffxp @k8s-ci-robot @BenTheElder @jbeda @mikedanese