Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76211 to release-1.11: Use Node-Problem-Detector v0.6.3 on GCI #76284

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Automated cherry pick of #76211 to release-1.11: Use Node-Problem-Detector v0.6.3 on GCI #76284

merged 1 commit into from
Apr 23, 2019

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Apr 8, 2019 •
edited

Cherry pick of #76211 on release-1.11.

#76211: Use Node-Problem-Detector v0.6.3 on GCI

This is part of #76209.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 8, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2019
@wangzhen127 wangzhen127 changed the title Automated cherry pick of #76211: Use Node-Problem-Detector v0.6.3 on GCI Automated cherry pick of #76211 to release-1.11: Use Node-Problem-Detector v0.6.3 on GCI Apr 8, 2019
@wangzhen127
Copy link
Member Author

/kind bug
/sig node
/sig gcp
/priority important-soon
/assign @Random-Liu

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/gcp priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 8, 2019
@Random-Liu Random-Liu added this to the v1.11 milestone Apr 9, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2019
@wangzhen127
Copy link
Member Author

/assign @dchen1107

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Random-Liu, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@wangzhen127
Copy link
Member Author

Assigning to branch manager and patch release manager.
/assign @calebamiles
/assign @foxish

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 53daefc into kubernetes:release-1.11 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingax10 jingax10 Awaiting requested review from jingax10

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@calebamiles calebamiles

@foxish foxish

@Random-Liu Random-Liu

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wangzhen127 @Random-Liu @dchen1107 @k8s-ci-robot @calebamiles @foxish