Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node-Problem-Detector v0.6.3 on GCI #76211

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Use Node-Problem-Detector v0.6.3 on GCI #76211

merged 1 commit into from
Apr 5, 2019

Conversation

wangzhen127
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:
Use Node-Problem-Detector v0.6.3 on GCI. NPD v0.6.3 fixes a bug in v0.6.0, where glog could potentially write too many files in tmp directory. This is part of #76209.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Currently v0.6.0 is being used.

Does this PR introduce a user-facing change?:

Fixes a NPD bug on GCI, so that it disables glog writing to files for log-counter

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 5, 2019
@wangzhen127
Copy link
Member Author

/kind bug
/sig node
/sig gcp
/priority important-soon
/assign @Random-Liu
/assign @yguo0905

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/gcp priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
@Random-Liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
@yguo0905
Copy link
Contributor

yguo0905 commented Apr 5, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3e954d3 into kubernetes:master Apr 5, 2019
@wangzhen127 wangzhen127 deleted the npd063 branch April 8, 2019 20:05
This was referenced Apr 8, 2019
Closed
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 10, 2019
@k8s-ci-robot
Merge pull request #76285 from wangzhen127/automated-cherry-pick-of-#…
d447e15 
…76211-upstream-release-1.12

Automated cherry pick of #76211 to release-1.12: Use Node-Problem-Detector v0.6.3 on GCI
k8s-ci-robot added a commit that referenced this pull request Apr 12, 2019
@k8s-ci-robot
Merge pull request #76287 from wangzhen127/automated-cherry-pick-of-#…
69b2bc0 
…76211-upstream-release-1.14

Automated cherry pick of #76211 to release-1.14: Use Node-Problem-Detector v0.6.3 on GCI
k8s-ci-robot added a commit that referenced this pull request Apr 13, 2019
@k8s-ci-robot
Merge pull request #76286 from wangzhen127/automated-cherry-pick-of-#…
75128f9 
…76211-upstream-release-1.13

Automated cherry pick of #76211 to release-1.13: Use Node-Problem-Detector v0.6.3 on GCI
@wojtek-t wojtek-t mentioned this pull request Apr 17, 2019
Closed
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2019
@k8s-ci-robot
Merge pull request #76284 from wangzhen127/automated-cherry-pick-of-#…
53daefc 
…76211-upstream-release-1.11

Automated cherry pick of #76211 to release-1.11: Use Node-Problem-Detector v0.6.3 on GCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@vishh vishh Awaiting requested review from vishh

Assignees

@Random-Liu Random-Liu

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wangzhen127 @Random-Liu @yguo0905 @k8s-ci-robot