Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node-Problem-Detector v0.6.3 on GCI #76211

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@wangzhen127
Copy link
Member

commented Apr 5, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:
Use Node-Problem-Detector v0.6.3 on GCI. NPD v0.6.3 fixes a bug in v0.6.0, where glog could potentially write too many files in tmp directory. This is part of #76209.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Currently v0.6.0 is being used.

Does this PR introduce a user-facing change?:

Fixes a NPD bug on GCI, so that it disables glog writing to files for log-counter
@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

/kind bug
/sig node
/sig gcp
/priority important-soon
/assign @Random-Liu
/assign @yguo0905

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2019

@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd063 branch from 1d44f60 to 953677d Apr 5, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed lgtm size/XS labels Apr 5, 2019

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2019

@yguo0905

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e954d3 into kubernetes:master Apr 5, 2019

17 checks passed

cla/linuxfoundation wangzhen127 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@wangzhen127 wangzhen127 deleted the wangzhen127:npd063 branch Apr 8, 2019

k8s-ci-robot added a commit that referenced this pull request Apr 10, 2019

Merge pull request #76285 from wangzhen127/automated-cherry-pick-of-#…
…76211-upstream-release-1.12

Automated cherry pick of #76211 to release-1.12: Use Node-Problem-Detector v0.6.3 on GCI

k8s-ci-robot added a commit that referenced this pull request Apr 12, 2019

Merge pull request #76287 from wangzhen127/automated-cherry-pick-of-#…
…76211-upstream-release-1.14

Automated cherry pick of #76211 to release-1.14: Use Node-Problem-Detector v0.6.3 on GCI

k8s-ci-robot added a commit that referenced this pull request Apr 13, 2019

Merge pull request #76286 from wangzhen127/automated-cherry-pick-of-#…
…76211-upstream-release-1.13

Automated cherry pick of #76211 to release-1.13: Use Node-Problem-Detector v0.6.3 on GCI

k8s-ci-robot added a commit that referenced this pull request Apr 23, 2019

Merge pull request #76284 from wangzhen127/automated-cherry-pick-of-#…
…76211-upstream-release-1.11

Automated cherry pick of #76211 to release-1.11: Use Node-Problem-Detector v0.6.3 on GCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.