Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh #76417

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh #76417

merged 1 commit into from
Apr 18, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 11, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh

Which issue(s) this PR fixes:

Ref #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 11, 2019
SataQiu
SataQiu commented Apr 11, 2019
View reviewed changes
hack/update-generated-runtime-dockerized.sh
@@ -18,7 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change reason:

In hack/update-generated-runtime-dockerized.sh line 21:
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
                     ^-- SC2128: Expanding an array without an index only gives the first element.

hack/update-generated-runtime-dockerized.sh Outdated

# Update boilerplate for the generated file.
echo "$(cat hack/boilerplate/boilerplate.generatego.txt ${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go)" > ${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go
cat hack/boilerplate/boilerplate.generatego.txt "${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go" > tmpfile && mv tmpfile "${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change reason:

In hack/update-generated-runtime-dockerized.sh line 57:
echo "$(cat hack/boilerplate/boilerplate.generatego.txt ${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go)" > ${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go
     ^-- SC2005: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                                                        ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                                                                  ^-- SC2086: Double quote to prevent globbing and word splitting.

In hack/update-generated-runtime-dockerized.sh line 57:
cat hack/boilerplate/boilerplate.generatego.txt "${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go" > "${KUBE_REMOTE_RUNTIME_ROOT}/api.pb.go"
                                                ^-- SC2094: Make sure not to read and write the same file in the same pipeline.
                                                                                          ^-- SC2094: Make sure not to read and write the same file in the same pipeline.

@SataQiu
Copy link
Member Author

SataQiu commented Apr 11, 2019

/sig release
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 11, 2019
@SataQiu SataQiu mentioned this pull request Apr 11, 2019
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2019
@SataQiu SataQiu force-pushed the fix-shell-update-generated-runtime-dockerized-20190411 branch from 28a6f01 to 974e0a4 Compare April 14, 2019 02:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 14, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2019
@SataQiu SataQiu force-pushed the fix-shell-update-generated-runtime-dockerized-20190411 branch 2 times, most recently from 98150d6 to bd7f7fe Compare April 18, 2019 06:37
@SataQiu
Copy link
Member Author

SataQiu commented Apr 18, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 18, 2019

/assign @BenTheElder @fejta

@SataQiu
Copy link
Member Author

SataQiu commented Apr 18, 2019

/test pull-kubernetes-verify
/test pull-kubernetes-e2e-gce-100-performance

fejta
fejta approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit d308368 into kubernetes:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@jbeda jbeda Awaiting requested review from jbeda

@sttts sttts Awaiting requested review from sttts

Assignees

@BenTheElder BenTheElder

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @fejta @BenTheElder