Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress registering GCE LB provider flag if missing on CommandLine. #76627

Merged
merged 1 commit into from
May 4, 2019
Merged

Suppress registering GCE LB provider flag if missing on CommandLine. #76627

merged 1 commit into from
May 4, 2019

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Apr 15, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes an issue with the GCE-specific cloud-provider-gce-lb-src-cidrs flag being added by default that breaks external cloud providers.

Which issue(s) this PR fixes:
Fixes #76205

Does this PR introduce a user-facing change?:

GCE-only flag `cloud-provider-gce-lb-src-cidrs` becomes optional for external cloud providers.

/sig cloud-provider

Verified on DigitalOcean's CCM currently being updated to 1.14.1.

/cc @dims @andrewsykim

@timoreimann
Suppress registering GCE LB provider flag if missing on CommandLine.
16c150c 
Fixes an issue with GCE-specific parameters breaking out-of-tree cloud
providers that do not host the flag in question.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @timoreimann. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 15, 2019
@timoreimann timoreimann mentioned this pull request Apr 15, 2019
Closed
@andrewsykim
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
andrewsykim
andrewsykim reviewed Apr 15, 2019
View reviewed changes
cmd/cloud-controller-manager/app/controllermanager.go
// the gce cloudprovider is removed.
globalflag.Register(namedFlagSets.FlagSet("generic"), "cloud-provider-gce-lb-src-cidrs")

if flag.CommandLine.Lookup("cloud-provider-gce-lb-src-cidrs") != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cheftako @mikedanese this was breaking implementations that didn't import the GCE provider

@andrewsykim
Copy link
Member

/approve
/lgtm
/hold

/assign @cheftako @mikedanese

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@andrewsykim
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@timoreimann
Copy link
Contributor Author

/retest

@andrewsykim
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit e1fa195 into kubernetes:master May 4, 2019
@timoreimann timoreimann deleted the handle-missing-gce-lb-flag-gracefully branch May 17, 2019 00:33
@deitch deitch mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@dims dims Awaiting requested review from dims

Assignees

@cheftako cheftako

@mikedanese mikedanese

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud-controller-manager won't build for out-of-tree external providers
5 participants
@timoreimann @k8s-ci-robot @andrewsykim @cheftako @mikedanese