Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck failures of cluster/gce/gci/shutdown.sh #76655

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix shellcheck failures of cluster/gce/gci/shutdown.sh #76655

merged 1 commit into from
Apr 24, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 16, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix shellcheck failures of cluster/gce/gci/shutdown.sh

Which issue(s) this PR fixes:

Ref #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2019
neolit123
neolit123 reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 17, 2019

/assign @yguo0905 @dchen1107 @filbranden

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 22, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 24, 2019

/assign @fejta @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 24, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 24, 2019

@neolit123
I have updated the code. Can you LGTM again?

@liggitt
Copy link
Member

liggitt commented Apr 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 24, 2019

/test pull-kubernetes-dependencies

@fejta
Copy link
Contributor

fejta commented Apr 24, 2019

/unassign

@k8s-ci-robot k8s-ci-robot merged commit 2c2e7a0 into kubernetes:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@mwielgus mwielgus Awaiting requested review from mwielgus

@vishh vishh Awaiting requested review from vishh

Assignees

@filbranden filbranden

@neolit123 neolit123

@liggitt liggitt

@dchen1107 dchen1107

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SataQiu @liggitt @k8s-ci-robot @fejta @neolit123 @filbranden @dchen1107 @yguo0905