Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused code in humanreadable.go #76681

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Removed unused code in humanreadable.go #76681

merged 1 commit into from
Apr 18, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Apr 16, 2019 •
edited

  • The server-side table generation functionality in humanreadable.go will eventually be separated from the client-side table printing functionality. This is another step in that direction.
  • Removes unused code in humanreadable.go
  • Moves FormatResourceName() to internalversion/printers.go, which is the only place that uses it. Makes the function unexportable.

Helps address:
kubernetes/kubectl#80

NONE

/kind cleanup
/assign

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@seans3
Copy link
Contributor Author

seans3 commented Apr 16, 2019

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2019
@liggitt
Copy link
Member

liggitt commented Apr 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@seans3
Copy link
Contributor Author

seans3 commented Apr 17, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Apr 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@seans3
Copy link
Contributor Author

seans3 commented Apr 17, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@seans3
Copy link
Contributor Author

seans3 commented Apr 17, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Apr 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 88d44f4 into kubernetes:master Apr 18, 2019
@seans3 seans3 deleted the humanreadable-cleanup branch August 21, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dshulyak dshulyak Awaiting requested review from dshulyak

Assignees

@liggitt liggitt

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @k8s-ci-robot @liggitt