Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use read lock in ServeHTTP #76784

Merged
merged 1 commit into from
May 2, 2019
Merged

Use read lock in ServeHTTP #76784

merged 1 commit into from
May 2, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Apr 18, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Currently ServeHTTP (in healthcheck.go) takes the write lock:

	h.hcs.lock.Lock()
	svc, ok := h.hcs.services[h.name]

Since it only reads from h.hcs.services, holding read lock should suffice.

Which issue(s) this PR fixes:
Fixes #76783

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tedyu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tedyu
Copy link
Contributor Author

tedyu commented Apr 18, 2019

cc @m1093782566

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 18, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Apr 18, 2019

/sig network

@m1093782566
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Apr 19, 2019

tests passed.

@m1093782566
please review

@tedyu
Copy link
Contributor Author

tedyu commented Apr 25, 2019

ping @m1093782566
you left comment on issue #76783 :-)

m1093782566
m1093782566 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@m1093782566 m1093782566 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Apr 25, 2019

Thanks @m1093782566
I wonder who would give /approve

@tedyu
Copy link
Contributor Author

tedyu commented Apr 26, 2019

ping @matchstick @thockin for approval

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit de83eef into kubernetes:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1093782566 m1093782566 m1093782566 approved these changes

@vishh vishh Awaiting requested review from vishh

Assignees

@m1093782566 m1093782566

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use read lock in ServeHTTP
4 participants
@tedyu @k8s-ci-robot @m1093782566 @smarterclayton