-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shellcheck failures of hack/grab-profiles.sh #76812
Fix shellcheck failures of hack/grab-profiles.sh #76812
Conversation
/sig release |
/test pull-kubernetes-e2e-gce |
e70b0c3
to
14775c4
Compare
/retest |
/test pull-kubernetes-dependencies |
/assign @fejta @BenTheElder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@@ -65,7 +65,7 @@ output_dir="." | |||
tunnel_port="${tunnel_port:-1234}" | |||
|
|||
args=$(getopt -o s:mho:k:c -l server:,master,heapster,output:,kubelet:,scheduler,controller-manager,help,inuse-space,inuse-objects,alloc-space,alloc-objects,cpu,kubelet-binary:,master-binary:,scheduler-binary:,controller-manager-binary:,scheduler-port:,controller-manager-port: -- "$@") | |||
if [[ $? -ne 0 ]]; then | |||
if [[ $? ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ! args=$(getopt -o ...); then
(does this work?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should work too, but this already can work here.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix shellcheck failures of hack/grab-profiles.sh
Which issue(s) this PR fixes:
Ref #72956
Special notes for your reviewer:
Does this PR introduce a user-facing change?: