Fix bug and golint failures of hack/verify-api-groups.sh #76834
Conversation
k8s-ci-robot
added
release-note-none
| @@ -112,8 +112,8 @@ for expected_install_package in "${expected_install_packages[@]}"; do | |||
| fi | |||
|
|
|||
| for known_version_file in "${known_version_files[@]}"; do | |||
| if ! grep -q "${expected_install_package}/install" ${known_version_files} ; then | |||
| echo "missing ${expected_install_package}/install from ${known_version_files}" | |||
| if ! grep -q "${expected_install_package}/install" "${known_version_file}" ; then | |||
There was a problem hiding this comment.
I think if you go digging the file on line 101 does not exist and we patched this out in one of the other scripts
There was a problem hiding this comment.
@liggitt might be someone to ask :^)
There was a problem hiding this comment.
@BenTheElder
Yes, this file does not exist.
pkg/client/clientset_generated/internal_clientset/import_known_versions.go: No such file or directory
But how do we fix it? Any suggestions? @liggitt
There was a problem hiding this comment.
this was removed in #71136
we can drop the clientset_generated/internal_clientset line
There was a problem hiding this comment.
Thanks a lot. @liggitt
I have updated the code.
SataQiu
force-pushed
the
fix-hack-shell-2019041905
branch
from
ee4b6e2
to
741caa4
Compare
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Fix bug and golint failures of hack/verify-api-groups.sh
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig testing