Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune literally all kube-apiserver internal client #71136

Conversation

@yue9944882
Copy link
Member

commented Nov 16, 2018

i dont think this will get into v1.13, so for now, it's just experimental.

/sig api-machienery
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and deads2k Nov 16, 2018

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch from 9941d97 to 2d8b6ab Nov 16, 2018

@yue9944882 yue9944882 changed the title Prune literally all k/k internal client Prune literally all kube-apiserver internal client Nov 16, 2018

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch 2 times, most recently from d36a8ac to fac5503 Nov 16, 2018

@@ -46,8 +47,7 @@ import (
"k8s.io/kubernetes/pkg/api/legacyscheme"
"k8s.io/kubernetes/pkg/api/testapi"
api "k8s.io/kubernetes/pkg/apis/core"
rbacapi "k8s.io/kubernetes/pkg/apis/rbac"

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Nov 16, 2018

Author Member

@deads2k 😺 i guess it should have been done in #63967

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch from fac5503 to 15d899b Nov 16, 2018

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch 3 times, most recently from b43003a to e2e985b Nov 16, 2018

@lavalamp

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

:) :)

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

/cc @yliaog

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch from eb16a11 to c8e3f89 Apr 4, 2019

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch 3 times, most recently from bcc679c to 16b941d Apr 8, 2019

@yue9944882

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

/test pull-kubernetes-integration

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch 3 times, most recently from 2bfe523 to 27e0fe2 Apr 8, 2019

@yue9944882 yue9944882 force-pushed the yue9944882:chore/prune-all-kk-internal-clientset branch from 27e0fe2 to 8f601d3 Apr 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@yue9944882: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke e2e985b link /test pull-kubernetes-e2e-gke
pull-kubernetes-e2e-kops-aws e2e985b link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yue9944882

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

/retest

@@ -106,7 +107,12 @@ func AddSystemPriorityClasses() genericapiserver.PostStartHookFunc {
_, err := schedClientSet.PriorityClasses().Get(pc.Name, metav1.GetOptions{})
if err != nil {
if apierrors.IsNotFound(err) {
_, err := schedClientSet.PriorityClasses().Create(pc)
// TODO: Remove this explicit conversion after scheduling api move to v1

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 9, 2019

Member

these are v1 in #73557

scheduling.SystemPriorityClasses() should probably return versioned objects (and the method might need to move to a different package to be able to do that)

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Apr 10, 2019

Author Member

fixing in this thread #76362

@@ -30,12 +31,12 @@ import (
"k8s.io/apiserver/pkg/registry/rest"
genericapiserver "k8s.io/apiserver/pkg/server"
serverstorage "k8s.io/apiserver/pkg/server/storage"
schedulingclient "k8s.io/client-go/kubernetes/typed/scheduling/v1beta1"

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 9, 2019

Member

use the v1 client

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Apr 10, 2019

Author Member

fixing in this thread #76362

ditto

@@ -71,7 +71,6 @@ INTERNAL_DIRS_CSV=$(IFS=',';echo "${INTERNAL_DIRS[*]// /,}";IFS=$)

# This can be called with one flag, --verify-only, so it works for both the
# update- and verify- scripts.
${clientgen} --input-base="k8s.io/kubernetes/pkg/apis" --input="${INTERNAL_DIRS_CSV}" "$@"

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 9, 2019

Member

drop INTERNAL_DIRS_CSV?

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Apr 10, 2019

Author Member

fixing here #76363

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

a couple nits, but since this is a rebase magnet, we can take those in follow-up PRs

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

good to see this done.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e2091b7 into kubernetes:master Apr 9, 2019

16 of 17 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation yue9944882 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

vdemeester pushed a commit to vdemeester/kubernetes that referenced this pull request Apr 10, 2019

Merge pull request kubernetes#76363 from yue9944882/chore/follow-up-p…
…rune-internal-client-codegen-scripts

Follow-up of kubernetes#71136: Clean up unused vars in codegen scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.