Prune literally all kube-apiserver internal client #71136

yue9944882 · 2018-11-16T16:07:13Z

i dont think this will get into v1.13, so for now, it's just experimental.

/sig api-machienery
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

yue9944882 · 2018-11-16T17:07:30Z

test/integration/auth/rbac_test.go

@@ -46,8 +47,7 @@ import (
 	"k8s.io/kubernetes/pkg/api/legacyscheme"
 	"k8s.io/kubernetes/pkg/api/testapi"
 	api "k8s.io/kubernetes/pkg/apis/core"
-	rbacapi "k8s.io/kubernetes/pkg/apis/rbac"


@deads2k 😺 i guess it should have been done in #63967

lavalamp · 2018-11-16T19:20:25Z

:) :)

jennybuckley · 2018-11-26T21:05:36Z

/cc @yliaog

yue9944882 · 2019-04-08T14:02:55Z

/test pull-kubernetes-integration

k8s-ci-robot · 2019-04-09T13:46:54Z

@yue9944882: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gke	e2e985b76f1684c0fe8473fb713786faf7c18010	link	`/test pull-kubernetes-e2e-gke`
pull-kubernetes-e2e-kops-aws	e2e985b76f1684c0fe8473fb713786faf7c18010	link	`/test pull-kubernetes-e2e-kops-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yue9944882 · 2019-04-09T14:07:44Z

/retest

liggitt · 2019-04-09T18:21:46Z

pkg/registry/scheduling/rest/storage_scheduling.go

@@ -106,7 +107,12 @@ func AddSystemPriorityClasses() genericapiserver.PostStartHookFunc {
 				_, err := schedClientSet.PriorityClasses().Get(pc.Name, metav1.GetOptions{})
 				if err != nil {
 					if apierrors.IsNotFound(err) {
-						_, err := schedClientSet.PriorityClasses().Create(pc)
+						// TODO: Remove this explicit conversion after scheduling api move to v1


these are v1 in #73557

scheduling.SystemPriorityClasses() should probably return versioned objects (and the method might need to move to a different package to be able to do that)

fixing in this thread #76362

liggitt · 2019-04-09T18:22:03Z

pkg/registry/scheduling/rest/storage_scheduling.go

@@ -30,12 +31,12 @@ import (
 	"k8s.io/apiserver/pkg/registry/rest"
 	genericapiserver "k8s.io/apiserver/pkg/server"
 	serverstorage "k8s.io/apiserver/pkg/server/storage"
+	schedulingclient "k8s.io/client-go/kubernetes/typed/scheduling/v1beta1"


use the v1 client

fixing in this thread #76362

ditto

liggitt · 2019-04-09T18:22:50Z

hack/update-codegen.sh

@@ -71,7 +71,6 @@ INTERNAL_DIRS_CSV=$(IFS=',';echo "${INTERNAL_DIRS[*]// /,}";IFS=$)

 # This can be called with one flag, --verify-only, so it works for both the
 # update- and verify- scripts.
-${clientgen} --input-base="k8s.io/kubernetes/pkg/apis" --input="${INTERNAL_DIRS_CSV}" "$@"


drop INTERNAL_DIRS_CSV?

fixing here #76363

liggitt · 2019-04-09T18:25:53Z

a couple nits, but since this is a rebase magnet, we can take those in follow-up PRs

/lgtm
/approve

k8s-ci-robot · 2019-04-09T18:26:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster/addons/fluentd-elasticsearch/OWNERS~~ [liggitt]
~~hack/OWNERS~~ [liggitt]
~~pkg/OWNERS~~ [liggitt]
~~test/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yliaog · 2019-04-09T20:21:50Z

good to see this done.

/lgtm

…rune-internal-client-codegen-scripts Follow-up of kubernetes#71136: Clean up unused vars in codegen scripts

…nal-client-scheduling-v1-api Follow-up of #71136: Switch system priority class usage to versioned (v1) api

kubernetes/kubernetes#71136

k8s-ci-robot requested review from caesarxuchao and deads2k November 16, 2018 16:07

k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 16, 2018

yue9944882 mentioned this pull request Nov 16, 2018

[UMBRELLA ISSUE] Prune hub-typed clienset/informer/lister from k/k #70657

Closed

5 tasks

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch from 9941d97 to 2d8b6ab Compare November 16, 2018 16:42

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 16, 2018

yue9944882 changed the title ~~Prune literally all k/k internal client~~ Prune literally all kube-apiserver internal client Nov 16, 2018

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch 2 times, most recently from d36a8ac to fac5503 Compare November 16, 2018 16:55

yue9944882 commented Nov 16, 2018

View reviewed changes

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch from fac5503 to 15d899b Compare November 16, 2018 17:26

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Nov 16, 2018

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch 3 times, most recently from b43003a to e2e985b Compare November 16, 2018 17:51

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2018

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch 3 times, most recently from bcc679c to 16b941d Compare April 8, 2019 13:16

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch 3 times, most recently from 2bfe523 to 27e0fe2 Compare April 9, 2019 10:45

yue9944882 added 4 commits April 9, 2019 21:43

remove internal client dependency in pkg/*

65ba58a

remove internal client references in cluster/*

b5e3acc

remove internal client from udpate-codegen script

ced03fb

prune internal client references from test/*

8f601d3

yue9944882 force-pushed the chore/prune-all-kk-internal-clientset branch from 27e0fe2 to 8f601d3 Compare April 9, 2019 13:44

liggitt reviewed Apr 9, 2019

View reviewed changes

k8s-ci-robot assigned liggitt Apr 9, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019

k8s-ci-robot assigned yliaog Apr 9, 2019

k8s-ci-robot merged commit e2091b7 into kubernetes:master Apr 9, 2019

vdemeester pushed a commit to vdemeester/kubernetes that referenced this pull request Apr 10, 2019

Merge pull request kubernetes#76363 from yue9944882/chore/follow-up-p…

29e50a0

…rune-internal-client-codegen-scripts Follow-up of kubernetes#71136: Clean up unused vars in codegen scripts

liggitt mentioned this pull request Apr 22, 2019

Fix bug and golint failures of hack/verify-api-groups.sh #76834

Merged

k8s-ci-robot added a commit that referenced this pull request Oct 24, 2019

Merge pull request #76362 from yue9944882/chore/follow-up-prune-inter…

5238e1c

…nal-client-scheduling-v1-api Follow-up of #71136: Switch system priority class usage to versioned (v1) api

wozniakjan added a commit to wozniakjan/autoscaler that referenced this pull request Oct 25, 2019

Update deprecated clientsets to client-go

54ce75f

kubernetes/kubernetes#71136

wozniakjan added a commit to wozniakjan/autoscaler that referenced this pull request Oct 25, 2019

Update deprecated clientsets to client-go

e3d5975

kubernetes/kubernetes#71136

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prune literally all kube-apiserver internal client #71136

Prune literally all kube-apiserver internal client #71136

yue9944882 commented Nov 16, 2018 •

edited

yue9944882 Nov 16, 2018

lavalamp commented Nov 16, 2018

jennybuckley commented Nov 26, 2018

yue9944882 commented Apr 8, 2019

k8s-ci-robot commented Apr 9, 2019 •

edited

yue9944882 commented Apr 9, 2019

liggitt Apr 9, 2019

yue9944882 Apr 10, 2019

liggitt Apr 9, 2019

yue9944882 Apr 10, 2019

liggitt Apr 9, 2019

yue9944882 Apr 10, 2019

liggitt commented Apr 9, 2019

k8s-ci-robot commented Apr 9, 2019

yliaog commented Apr 9, 2019

Prune literally all kube-apiserver internal client #71136

Prune literally all kube-apiserver internal client #71136

Conversation

yue9944882 commented Nov 16, 2018 • edited

yue9944882 Nov 16, 2018

Choose a reason for hiding this comment

lavalamp commented Nov 16, 2018

jennybuckley commented Nov 26, 2018

yue9944882 commented Apr 8, 2019

k8s-ci-robot commented Apr 9, 2019 • edited

yue9944882 commented Apr 9, 2019

liggitt Apr 9, 2019

Choose a reason for hiding this comment

yue9944882 Apr 10, 2019

Choose a reason for hiding this comment

liggitt Apr 9, 2019

Choose a reason for hiding this comment

yue9944882 Apr 10, 2019

Choose a reason for hiding this comment

liggitt Apr 9, 2019

Choose a reason for hiding this comment

yue9944882 Apr 10, 2019

Choose a reason for hiding this comment

liggitt commented Apr 9, 2019

k8s-ci-robot commented Apr 9, 2019

yliaog commented Apr 9, 2019

yue9944882 commented Nov 16, 2018 •

edited

k8s-ci-robot commented Apr 9, 2019 •

edited