Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh #76835

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh #76835

merged 1 commit into from
Apr 23, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 19, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh

Which issue(s) this PR fixes:

Ref #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig testing

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 22, 2019

/assign @fejta @BenTheElder

fejta
fejta reviewed Apr 22, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

hack/verify-boilerplate.sh Outdated
files_need_boilerplate=()
while IFS=$'\n' read -r line; do
files_need_boilerplate+=( "$line" )
done < <(${boiler} "$@")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe $boiler should be in quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fejta
I checked the details of the failure, which was caused by the conflict of hack/.shellcheck_failures.
I've updated the code now.
${boiler} doesn't have to be in double quotes, the shellcheck test can pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but it should be quoted, this will not work correctly if there's a space in $BASH_SOURCE (try mkdir -p "/tmp/very exciting dir/" && mv kubernetes "/tmp/very exciting dir" && cd "/tmp/very exciting dir" && hack/verify-boilerplate.sh)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @fejta !
Updated.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@SataQiu SataQiu force-pushed the fix-shellcheck-hack-20190420 branch from b3fb9f0 to b297e84 Compare April 23, 2019 02:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
fejta
fejta reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hack/verify-boilerplate.sh Outdated
files_need_boilerplate=()
while IFS=$'\n' read -r line; do
files_need_boilerplate+=( "$line" )
done < <(${boiler} "$@")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but it should be quoted, this will not work correctly if there's a space in $BASH_SOURCE (try mkdir -p "/tmp/very exciting dir/" && mv kubernetes "/tmp/very exciting dir" && cd "/tmp/very exciting dir" && hack/verify-boilerplate.sh)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@SataQiu SataQiu force-pushed the fix-shellcheck-hack-20190420 branch from b297e84 to 2704abf Compare April 23, 2019 05:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
fejta
fejta reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit e6390ce into kubernetes:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@sttts sttts Awaiting requested review from sttts

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@BenTheElder BenTheElder

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @fejta @BenTheElder