Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rancher Credential Provider from upstream kubernetes #77099

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Remove Rancher Credential Provider from upstream kubernetes #77099

merged 1 commit into from
Apr 26, 2019

Conversation

dims
Copy link
Member

@dims dims commented Apr 25, 2019

This is useful only in rancher environment, they are using this in a
very old branch (1.6), they are currently at 2.2.x. There is just no
point in us carrying this code as this is not useful to anyone else
outside of the rancher environment. Let us please remove this code from
upstream.

Change-Id: I5196d0edd79a7809c3a04e6028ddbd01063f224b

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #77098

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Rancher credential provider has now been removed

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@dims
Copy link
Member Author

dims commented Apr 25, 2019

/assign @wlan0
cc @alena1108
/sig cloud-provider
/area cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2019
@dims
Copy link
Member Author

dims commented Apr 25, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Apr 25, 2019
@dims
Copy link
Member Author

dims commented Apr 25, 2019

/assign @deads2k @liggitt

@dims
Copy link
Member Author

dims commented Apr 25, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

do we have an explicit ack that this is unused in current rancher deployments?

@dims
Copy link
Member Author

dims commented Apr 25, 2019

@liggitt yes in #77098 (comment)

@dims dims force-pushed the remove-rancher-credential-provider-from-upstream-kubernetes branch from de3ce31 to 56a6733 Compare April 25, 2019 22:03
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 25, 2019
@dims dims force-pushed the remove-rancher-credential-provider-from-upstream-kubernetes branch from 56a6733 to 61baa13 Compare April 25, 2019 22:17
@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

I found it a little hard to tell from that if that was an official ack. Are we certain this is unused?

@alena1108
Copy link
Contributor

@liggitt I work for Rancher, and this code leverages an older - 1.x - version of the product. We are planning to maintain it for some time, but it's ok to remove the Rancher credential provider code from the upstream k8s. We can maintain it in our own k8s fork.

@dims
Remove Rancher Credential Provider from upstream kubernetes
edf8577 
This is useful only in rancher environment, they are using this in a
very old branch (1.6), they are currently at 2.2.x. There is just no
point in us carrying this code as this is not useful to anyone else
outside of the rancher environment. Let us please remove this code from
upstream.

Change-Id: I5196d0edd79a7809c3a04e6028ddbd01063f224b
@dims dims force-pushed the remove-rancher-credential-provider-from-upstream-kubernetes branch from 61baa13 to edf8577 Compare April 25, 2019 23:10
@liggitt
Copy link
Member

liggitt commented Apr 26, 2019

/lgtm
/approve
per #77099 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2776cc1 into kubernetes:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@liggitt liggitt

@wlan0 wlan0

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Rancher Credential Provider from upstream kubernetes
7 participants
@dims @liggitt @alena1108 @k8s-ci-robot @fejta-bot @wlan0 @deads2k