Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "override ETCD_SERVER with https instead http when mTLS is enabled" #77158

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Revert "override ETCD_SERVER with https instead http when mTLS is enabled" #77158

merged 1 commit into from
Apr 27, 2019

Conversation

wojtek-t
Copy link
Member

Reverts #74690

Reverting for now to verify if that is the reason for some of the regressions we're seeing:
#77127
#77080

If that's not the case, we will re-revert, if that's really the case, we should figure out why the cpu increase is so huge - it's definitely not expected...

From @wenjiaswe offline:
"I agree, for now, let's temporarily revert it back and see how much it would help to save time. "

@mikedanese - FYI

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2019
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 27, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 27, 2019
@wojtek-t wojtek-t added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 27, 2019
@wenjiaswe
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2019
@wenjiaswe
Copy link
Contributor

Thanks @wojtek-t!

@jpbetz
Copy link
Contributor

jpbetz commented Apr 27, 2019

/lgtm

@mm4tt
Copy link
Contributor

mm4tt commented Apr 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenjiaswe
Copy link
Contributor

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 1039fee into master Apr 27, 2019
@imkin imkin mentioned this pull request Apr 29, 2019
Closed
@wenjiaswe wenjiaswe mentioned this pull request Apr 30, 2019
Closed
@krzysied krzysied mentioned this pull request May 6, 2019
Closed
@wenjiaswe wenjiaswe mentioned this pull request May 7, 2019
Merged
@cblecker cblecker deleted the revert-74690-etcdserverhttp branch June 19, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@jpbetz jpbetz

@mm4tt mm4tt

@krzysied krzysied

@wenjiaswe wenjiaswe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wojtek-t @k8s-ci-robot @wenjiaswe @jpbetz @mm4tt @krzysied