Increase maxMsgSize for dockershim #77165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the grpc max message size to be the same as the value defined in `pkg/kubelet/remote/utils.go`. Increase the limit because, `ListPodSandbox` (and possibly other) calls are hitting the limit. Long term, the best solution to this issue is to use pagination, but that is not currently available.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubelet
sig/node
|
/approve @Random-Liu thanks :) |
|
/test pull-kubernetes-integration |
|
/assign @Random-Liu @derekwaynecarr /lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks for the change. Agree it should have been kept in sync with remote CRI. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, mattjmcnaughton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mattjmcnaughton
deleted the
mattjmcnaughton/77138-increase-max-msg-size-dockershim
branch
This was referenced Oct 25, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 29, 2019
…-#77165-upstream-release-1.14 Automated cherry pick of #77165: Increase maxMsgSize for dockershim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Increase the grpc max message size to be the same as the value defined
in
pkg/kubelet/remote/utils.go.Increase the limit because,
ListPodSandbox(and possibly other) callsare hitting the limit. Long term, the best solution to this issue is to
use pagination, but that is not currently available.
Which issue(s) this PR fixes:
Fixes #77138
Special notes for your reviewer:
cc @dims
Does this PR introduce a user-facing change?: