Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: implement structural schema condition #77207

Merged
merged 7 commits into from
May 9, 2019
Merged

apiextensions: implement structural schema condition #77207

merged 7 commits into from
May 9, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Apr 29, 2019 •
edited

Imlement KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190425-structural-openapi.md.

* Add a condition NonStructuralSchema to CustomResourceDefinition listing Structural Schema violations as defined in KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190425-structural-openapi.md. CRD authors should update their validation schemas to be structural in order to participate in future CRD features.
* CRD validation schemas get support for `x-kubernetes-embedded-resource: true` to specify `RawExtensions` in OpenAPI and to enforce coercing and validation of TypeMeta and ObjectMeta.
* CRD validation schemas get support for `x-kubernetes-int-or-string: true` to specify `intstr.IntOrString` in OpenAPI.
* CRD validation schemas get support for `x-kubernetes-preserve-unknown-fields: true` to control pruning via OpenAPI for parts of CustomResources.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2019
@sttts
Copy link
Contributor Author

sttts commented Apr 29, 2019

/assign @apelisse @liggitt

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 29, 2019
@sttts sttts force-pushed the sttts-structural-schema branch 2 times, most recently from 96eb99f to 63c66f4 Compare April 29, 2019 12:50
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2019
@sttts sttts force-pushed the sttts-structural-schema branch 2 times, most recently from dd6464d to be95689 Compare April 29, 2019 15:28
@sttts sttts added this to the v1.15 milestone Apr 29, 2019
@liggitt liggitt added this to Assigned in API Reviews Apr 29, 2019
@sttts sttts changed the title WIP: apiextensions: add structural schema support apiextensions: add structural schema support Apr 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2019
@sttts
Copy link
Contributor Author

sttts commented Apr 29, 2019

@apelisse @liggitt this is ready for a first review.

@liggitt
Copy link
Member

liggitt commented Apr 29, 2019

thanks, will look after KEP deadline tomorrow night... working on getting everything reviewed for that

@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 29, 2019
@liggitt
Copy link
Member

liggitt commented May 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@liggitt
Copy link
Member

liggitt commented May 9, 2019

immediate follow-ups:

@sttts sttts force-pushed the sttts-structural-schema branch from 6e64994 to 01ab300 Compare May 9, 2019 15:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@liggitt
Copy link
Member

liggitt commented May 9, 2019

saw the vet error

/lgtm

@apelisse
Copy link
Member

apelisse commented May 9, 2019

/assign @jennybuckley

@sttts sttts mentioned this pull request May 9, 2019
Merged
@liggitt liggitt moved this from Changes requested to Completed, 1.15 in API Reviews May 9, 2019
@sttts sttts force-pushed the sttts-structural-schema branch from 01ab300 to c836a25 Compare May 9, 2019 19:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@liggitt
Copy link
Member

liggitt commented May 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8efea56 into kubernetes:master May 9, 2019
@sttts sttts deleted the sttts-structural-schema branch May 10, 2019 07:08
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions May 13, 2019
@sttts sttts mentioned this pull request Jun 10, 2019
Merged
@resouer resouer mentioned this pull request May 1, 2020
Closed
@kazk kazk mentioned this pull request Dec 19, 2020
Merged
@shekhar-rajak shekhar-rajak mentioned this pull request Jan 26, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@pmorie pmorie Awaiting requested review from pmorie

@jpbetz jpbetz Awaiting requested review from jpbetz

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

Assignees

@liggitt liggitt

@apelisse apelisse

@jennybuckley jennybuckley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.15
Custom Resource Definitions
Complete
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @liggitt @fedebongio @k8s-ci-robot @apelisse @jennybuckley