Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve existing namespace when using kubectl set --local #77267

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 30, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Uses existing namespace info in manifests to determine whether to preserve namespace info when running commands locally without RESTMapper info

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#639

Does this PR introduce a user-facing change?:

Preserves existing namespace information in manifests when running `kubectl set ... --local` commands

/sig cli
/cc @seans3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 30, 2019
@seans3
Copy link
Contributor

seans3 commented Apr 30, 2019

/retest

@seans3
Copy link
Contributor

seans3 commented Apr 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2019
@liggitt liggitt added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1e01523 into kubernetes:master Apr 30, 2019
@liggitt liggitt deleted the kubectl-set-local-namespace branch May 6, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl set env deletes namespace
3 participants