Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse integration test storage setup onto actual storage config #77330

Merged
merged 1 commit into from
May 2, 2019
Merged

Collapse integration test storage setup onto actual storage config #77330

merged 1 commit into from
May 2, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 2, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Deduplicates the places we set up api server storage. Would simplify changes like #77139

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2019
@liggitt liggitt mentioned this pull request May 2, 2019
Merged
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
BenTheElder
BenTheElder reviewed May 2, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively looks reasonable, but i'm not familiar enough with this code, we should probably assign another reviewer

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/assign @deads2k

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/assign @sttts

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2019
@sttts
Copy link
Contributor

sttts commented May 2, 2019

Less custom test master plumbing is always good. We still have far too much of that. So this goes into the right direction.

We might want to look into more use of https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-apiserver/app/testing/testserver.go#L76.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit c3e8a43 into kubernetes:master May 2, 2019
@liggitt liggitt deleted the collapse-integration-storage-config branch May 6, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@sttts sttts

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @sttts @BenTheElder @deads2k