Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: use networking api group for default storage of ingress #77139

Merged

Conversation

@cmluciano
Copy link
Member

commented Apr 26, 2019

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
Stores ingress group in networking.v1beta1 API group by default

Which issue(s) this PR fixes:
Related kubernetes/enhancements#758

Special notes for your reviewer:

  • These tests are currently failing, but I wanted to get this PR up for early review. These changes are similar to those we had to made when NP went through the same change, but things may have changed since I last worked on k8s api code.

Does this PR introduce a user-facing change?:

ingress objects are now persisted in etcd using the networking.k8s.io/v1beta1 version
@cmluciano

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

/sig network

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

/assign @bowei

@cmluciano cmluciano force-pushed the cmluciano:cml/ingressnetv1beta1default branch from bbe0649 to 8bb02df Apr 29, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

/remove-sig api-machinery

@cmluciano cmluciano force-pushed the cmluciano:cml/ingressnetv1beta1default branch from 7c7e268 to daf0346 May 1, 2019

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

This should be ready for review

/assign @thockin

@cmluciano cmluciano marked this pull request as ready for review May 1, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 1, 2019

storage version hash needs updating:

--- FAIL: TestStorageVersionHashes (0.20s)
master_test.go:415: expect the storageVersionHash of extensions/v1beta1/ingresses to be "Ejja63IbU0E=", got "ZOAfGflaKd0="
master_test.go:415: expect the storageVersionHash of networking.k8s.io/v1beta1/ingresses to be "Ejja63IbU0E=", got "ZOAfGflaKd0="
cmluciano added 2 commits Mar 29, 2019
ingress: use networking api group for default storage of ingress
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

The change to registrytest was found by liggitt to mitigate a NPE error.
This is necessary since ingress is a cohabitating resource that is not
stored in the default version for the networking resource.

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
ingress: generated files netv1beta1
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

@cmluciano cmluciano force-pushed the cmluciano:cml/ingressnetv1beta1default branch from daf0346 to dd891bb May 1, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 1, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

looks like there's yet another place we're building a storage factory in test/integration/framework/master_utils.go

opened #77330 to collapse onto the standard apiserver storage config. once that merges, this should go green

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@liggitt See anything wrong with my release note format?

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

space between ``` and release-note

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 83f769c into kubernetes:master May 2, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation cmluciano authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.