Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: use networking api group for default storage of ingress #77139

Merged
merged 2 commits into from May 2, 2019
Merged

ingress: use networking api group for default storage of ingress #77139

merged 2 commits into from May 2, 2019

Conversation

cmluciano
Copy link

@cmluciano cmluciano commented Apr 26, 2019 •
edited

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
Stores ingress group in networking.v1beta1 API group by default

Which issue(s) this PR fixes:
Related kubernetes/enhancements#758

Special notes for your reviewer:

  • These tests are currently failing, but I wanted to get this PR up for early review. These changes are similar to those we had to made when NP went through the same change, but things may have changed since I last worked on k8s api code.

Does this PR introduce a user-facing change?:

ingress objects are now persisted in etcd using the networking.k8s.io/v1beta1 version

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 26, 2019
@cmluciano
Copy link
Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 26, 2019
@cmluciano
Copy link
Author

/assign @bowei

@cmluciano cmluciano force-pushed the cml/ingressnetv1beta1default branch from bbe0649 to 8bb02df Compare April 29, 2019 16:54
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 29, 2019
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 1, 2019
@cmluciano cmluciano force-pushed the cml/ingressnetv1beta1default branch from 7c7e268 to daf0346 Compare May 1, 2019 18:12
@cmluciano
Copy link
Author

This should be ready for review

/assign @thockin

@cmluciano cmluciano marked this pull request as ready for review May 1, 2019 18:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2019
@liggitt
Copy link
Member

liggitt commented May 1, 2019

storage version hash needs updating:

--- FAIL: TestStorageVersionHashes (0.20s)
master_test.go:415: expect the storageVersionHash of extensions/v1beta1/ingresses to be "Ejja63IbU0E=", got "ZOAfGflaKd0="
master_test.go:415: expect the storageVersionHash of networking.k8s.io/v1beta1/ingresses to be "Ejja63IbU0E=", got "ZOAfGflaKd0="

Christopher M. Luciano added 2 commits May 1, 2019 15:14
ingress: use networking api group for default storage of ingress
4bac85c 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

The change to registrytest was found by liggitt to mitigate a NPE error.
This is necessary since ingress is a cohabitating resource that is not
stored in the default version for the networking resource.

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
ingress: generated files netv1beta1
dd891bb 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano cmluciano force-pushed the cml/ingressnetv1beta1default branch from daf0346 to dd891bb Compare May 1, 2019 19:41
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented May 2, 2019 •
edited

looks like there's yet another place we're building a storage factory in test/integration/framework/master_utils.go

opened #77330 to collapse onto the standard apiserver storage config. once that merges, this should go green

@liggitt liggitt mentioned this pull request May 2, 2019
Merged
@liggitt
Copy link
Member

liggitt commented May 2, 2019

/retest

@liggitt
Copy link
Member

liggitt commented May 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@cmluciano
Copy link
Author

@liggitt See anything wrong with my release note format?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 2, 2019
@liggitt
Copy link
Member

liggitt commented May 2, 2019

space between ``` and release-note

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 83f769c into kubernetes:master May 2, 2019
@liggitt liggitt added this to the v1.15 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@bowei bowei

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cmluciano @fedebongio @liggitt @fejta-bot @k8s-ci-robot @bowei @thockin